chore: AccountTrackerController migration (#36808)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR concludes the migration to `AccountsTrackerController` from
core. This is necessary in order to benefit from performance changes
added and planned to the core controller.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36808?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1368

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.




<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Replaces the local AccountTrackerController with the core one, removes
legacy tracker/polling and gas-limit state, and updates state shape,
selectors, metrics, tests, and dependencies accordingly.
> 
> - **Core/Controllers**:
> - Replace local `AccountTrackerController` with
`@metamask/assets-controllers` version; update init, messengers, allowed
actions/events, and wiring.
> - Remove legacy files (`account-tracker-controller*`, `batch-utils*`,
`constants/contracts.ts`, types) and related listeners/APIs (e.g.,
balance-update on tx, account syncing).
> - Drop `accounts` and `currentBlockGasLimit*` from background/UI
state; rely on `accountsByChainId` only; update sentry state and types.
> - Remove account-tracker polling APIs/hook; stop exposing start/stop
polling from background.
> - Bump `@metamask/assets-controllers` to `^86.0.0`; update LavaMoat
policies.
> - Preferences: add `isMultiAccountBalancesEnabled` mirroring
`useMultiAccountBalanceChecker`.
> - **MetaMaskController**:
> - Remove tracker syncing/clearing and tx-balance update; use
checksummed addresses in `getBalance` and metrics.
> - **Transactions/Init**:
>   - Simplify listeners; stop updating balances on tx events.
> - **UI/Selectors & Send Flow**:
> - Normalize `accountsByChainId` address handling (lowercasing in
selectors); remove `getBlockGasLimit` usage; adjust gas estimate logic.
> - Fix `token-search` null guard; update tests/fixtures to checksummed
addresses.
> - **Metrics/Telemetry**:
> - Compute `number_of_accounts` from `accountsByChainId`; update
masked/removed fields.
> - **Tests/Fixtures**:
> - Update mocks to checksummed addresses; remove obsolete
expectations/delays; align with new state shape.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
3cfb04e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: bergarces

.storybook/test-data.js

@@ -743,47 +743,26 @@ const state = {
     swapsWelcomeMessageHasBeenShown: true,
     defaultHomeActiveTabName: 'Tokens',
     network: '5',
-    accounts: {
-      '0x64a845a5b02460acf8a3d84503b0d68d028b4bb4': {
-        address: '0x64a845a5b02460acf8a3d84503b0d68d028b4bb4',
-        balance: '0x176e5b6f173ebe66',
-      },
-      '0xb19ac54efa18cc3a14a5b821bfec73d284bf0c5e': {
-        address: '0xb19ac54efa18cc3a14a5b821bfec73d284bf0c5e',
-        balance: '0x2d3142f5000',
-      },
-      '0x9d0ba4ddac06032527b140912ec808ab9451b788': {
-        address: '0x9d0ba4ddac06032527b140912ec808ab9451b788',
-        balance: '0x15f6f0b9d4f8d000',
-      },
-    },
     accountsByChainId: {
       '0x1': {
-        '0x64a845a5b02460acf8a3d84503b0d68d028b4bb4': { balance: '0x0' },
-        '0xb19ac54efa18cc3a14a5b821bfec73d284bf0c5e': {
+        '0x64A845a5b02460ACf8a3D84503b0D68d028B4bb4': { balance: '0x0' },
+        '0xb19Ac54EfA18CC3A14A5B821bFeC73d284Bf0c5e': {
           balance: '0xcaf5317161f400',
         },
-        '0x9d0ba4ddac06032527b140912ec808ab9451b788': { balance: '0x0' },
+        '0x9D0ba4DDAC06032527B140912EC808ab9451b788': { balance: '0x0' },
       },
       '0x5': {
-        '0x64a845a5b02460acf8a3d84503b0d68d028b4bb4': {
-          address: '0x64a845a5b02460acf8a3d84503b0d68d028b4bb4',
+        '0x64A845a5b02460ACf8a3D84503b0D68d028B4bb4': {
           balance: '0x176e5b6f173ebe66',
         },
-        '0xb19ac54efa18cc3a14a5b821bfec73d284bf0c5e': {
-          address: '0xb19ac54efa18cc3a14a5b821bfec73d284bf0c5e',
+        '0xb19Ac54EfA18CC3A14A5B821bFeC73d284Bf0c5e': {
           balance: '0x2d3142f5000',
         },
-        '0x9d0ba4ddac06032527b140912ec808ab9451b788': {
-          address: '0x9d0ba4ddac06032527b140912ec808ab9451b788',
+        '0x9D0ba4DDAC06032527B140912EC808ab9451b788': {
           balance: '0x15f6f0b9d4f8d000',
         },
       },
     },
-    currentBlockGasLimit: '0x793af4',
-    currentBlockGasLimitByChainId: {
-      '0x5': '0x793af4',
-    },
     transactions: [
       {
         chainId: '0x38',

app/scripts/background.js

@@ -632,10 +632,7 @@ function saveTimestamp() {
  * @property {boolean} welcomeScreen - True if welcome screen should be shown.
  * @property {string} currentLocale - A locale string matching the user's preferred display language.
  * @property {string} networkStatus - Either "unknown", "available", "unavailable", or "blocked", depending on the status of the currently selected network.
- * @property {object} accounts - An object mapping lower-case hex addresses to objects with "balance" and "address" keys, both storing hex string values.
  * @property {object} accountsByChainId - An object mapping lower-case hex addresses to objects with "balance" and "address" keys, both storing hex string values keyed by chain id.
- * @property {hex} currentBlockGasLimit - The most recently seen block gas limit, in a lower case hex prefixed string.
- * @property {object} currentBlockGasLimitByChainId - The most recently seen block gas limit, in a lower case hex prefixed string keyed by chain id.
  * @property {object} unapprovedPersonalMsgs - An object of messages pending approval, mapping a unique ID to the options.
  * @property {number} unapprovedPersonalMsgCount - The number of messages in unapprovedPersonalMsgs.
  * @property {object} unapprovedEncryptionPublicKeyMsgs - An object of messages pending approval, mapping a unique ID to the options.

app/scripts/constants/contracts.ts

@@ -14,10 +14,7 @@ export const SENTRY_BACKGROUND_STATE = {
     },
   },
   AccountTracker: {
-    accounts: false,
     accountsByChainId: false,
-    currentBlockGasLimit: true,
-    currentBlockGasLimitByChainId: true,
   },
   AddressBookController: {
     addressBook: false,

app/scripts/constants/sentry-state.ts

@@ -4,12 +4,19 @@ import {
   Messenger,
   MockAnyNamespace,
 } from '@metamask/messenger';
+import { RemoteFeatureFlagControllerGetStateAction } from '@metamask/remote-feature-flag-controller';
+import { AccountTrackerController } from '@metamask/assets-controllers';
 import {
-  NetworkControllerGetSelectedNetworkClientAction,
-  NetworkControllerNetworkDidChangeEvent,
+  AutoManagedNetworkClient,
+  CustomNetworkClientConfiguration,
+  NetworkControllerGetNetworkClientByIdAction,
+  NetworkControllerGetStateAction,
+  NetworkState,
 } from '@metamask/network-controller';
-import { RemoteFeatureFlagControllerGetStateAction } from '@metamask/remote-feature-flag-controller';
-import AccountTrackerController from '../controllers/account-tracker-controller';
+import {
+  PreferencesControllerGetStateAction,
+  PreferencesState,
+} from '@metamask/preferences-controller';
 import { ControllerInitRequest } from './types';
 import { buildControllerInitRequestMock } from './test/utils';
 import {
@@ -20,13 +27,15 @@ import {
 } from './messengers';
 import { AccountTrackerControllerInit } from './account-tracker-controller-init';
 
-jest.mock('../controllers/account-tracker-controller');
+jest.mock('@metamask/assets-controllers');
 
 function getInitRequestMock(
   baseMessenger = new Messenger<
     MockAnyNamespace,
-    | NetworkControllerGetSelectedNetworkClientAction
     | RemoteFeatureFlagControllerGetStateAction
+    | NetworkControllerGetStateAction
+    | NetworkControllerGetNetworkClientByIdAction
+    | PreferencesControllerGetStateAction
     | ActionConstraint,
     never
   >({ namespace: MOCK_ANY_NAMESPACE }),
@@ -36,17 +45,6 @@ function getInitRequestMock(
     AccountTrackerControllerInitMessenger
   >
 > {
-  baseMessenger.registerActionHandler(
-    'NetworkController:getSelectedNetworkClient',
-    () => ({
-      // @ts-expect-error: Partial mock.
-      provider: {},
-
-      // @ts-expect-error: Partial mock.
-      blockTracker: {},
-    }),
-  );
-
   baseMessenger.registerActionHandler(
     'RemoteFeatureFlagController:getState',
     () => ({
@@ -57,6 +55,30 @@ function getInitRequestMock(
     }),
   );
 
+  baseMessenger.registerActionHandler(
+    'NetworkController:getState',
+    () =>
+      ({
+        selectedNetworkClientId: '0x1',
+      }) as NetworkState,
+  );
+
+  baseMessenger.registerActionHandler(
+    'NetworkController:getNetworkClientById',
+    () =>
+      ({
+        configuration: { chainId: '0x1' },
+      }) as unknown as AutoManagedNetworkClient<CustomNetworkClientConfiguration>,
+  );
+
+  baseMessenger.registerActionHandler(
+    'PreferencesController:getState',
+    () =>
+      ({
+        useExternalServices: true,
+      }) as unknown as PreferencesState,
+  );
+
   const requestMock = {
     ...buildControllerInitRequestMock(),
     controllerMessenger: getAccountTrackerControllerMessenger(baseMessenger),
@@ -78,11 +100,11 @@ describe('AccountTrackerControllerInit', () => {
     const controllerMock = jest.mocked(AccountTrackerController);
     expect(controllerMock).toHaveBeenCalledWith({
       messenger: expect.any(Object),
-      state: { accounts: {} },
-      provider: expect.any(Object),
-      blockTracker: expect.any(Object),
-      getNetworkIdentifier: expect.any(Function),
+      getStakedBalanceForChain: expect.any(Function),
+      includeStakedAssets: false,
+      allowExternalServices: expect.any(Function),
       accountsApiChainIds: expect.any(Function),
+      fetchingEnabled: expect.any(Function),
     });
   });
 
@@ -99,27 +121,4 @@ describe('AccountTrackerControllerInit', () => {
     expect(chainIds).toContain('0x38'); // BSC
     expect(chainIds).toContain('0xe708'); // Linea
   });
-
-  it('calls `updateAccounts` when `NetworkController:networkDidChange` is emitted', () => {
-    const messenger = new Messenger<
-      MockAnyNamespace,
-      | NetworkControllerGetSelectedNetworkClientAction
-      | RemoteFeatureFlagControllerGetStateAction
-      | ActionConstraint,
-      NetworkControllerNetworkDidChangeEvent
-    >({ namespace: MOCK_ANY_NAMESPACE });
-
-    const request = getInitRequestMock(messenger);
-    const { controller } = AccountTrackerControllerInit(request);
-
-    expect(controller.updateAccounts).not.toHaveBeenCalled();
-
-    messenger.publish('NetworkController:networkDidChange', {
-      selectedNetworkClientId: 'test',
-      networkConfigurationsByChainId: {},
-      networksMetadata: {},
-    });
-
-    expect(controller.updateAccounts).toHaveBeenCalledTimes(1);
-  });
 });

app/scripts/controller-init/account-tracker-controller-init.test.ts

@@ -1,56 +1,39 @@
-import { assert } from '@metamask/utils';
-import { getProviderConfig } from '../../../shared/modules/selectors/networks';
-import { NETWORK_TYPES } from '../../../shared/constants/network';
-import AccountTrackerController from '../controllers/account-tracker-controller';
+import { AccountTrackerController } from '@metamask/assets-controllers';
+import { NetworkClientId } from '@metamask/network-controller';
 import { ControllerInitFunction } from './types';
 import {
   AccountTrackerControllerInitMessenger,
   AccountTrackerControllerMessenger,
 } from './messengers';
 
-/**
- * Initialize the account tracker controller.
- *
- * @param request - The request object.
- * @param request.controllerMessenger - The messenger to use for the controller.
- * @param request.initMessenger - The messenger to use for initialization.
- * @returns The initialized controller.
- */
 export const AccountTrackerControllerInit: ControllerInitFunction<
   AccountTrackerController,
   AccountTrackerControllerMessenger,
   AccountTrackerControllerInitMessenger
-> = ({ controllerMessenger, initMessenger }) => {
-  const { provider, blockTracker } =
-    initMessenger.call('NetworkController:getSelectedNetworkClient') ?? {};
+> = ({ controllerMessenger, initMessenger, getController }) => {
+  const getAssetsContractController = () =>
+    getController('AssetsContractController');
 
-  assert(
-    provider,
-    'Provider is required to initialize AccountTrackerController.',
-  );
-
-  assert(
-    blockTracker,
-    'Block tracker is required to initialize AccountTrackerController.',
-  );
+  const onboardingController = () => getController('OnboardingController');
 
   const controller = new AccountTrackerController({
-    state: { accounts: {} },
     messenger: controllerMessenger,
-    provider,
-    blockTracker,
-    getNetworkIdentifier: (providerConfig): string => {
-      const metamask = initMessenger.call('NetworkController:getState');
-
-      const config =
-        providerConfig ??
-        getProviderConfig({
-          metamask,
-        });
-
-      return config.type === NETWORK_TYPES.RPC && config.rpcUrl
-        ? config.rpcUrl
-        : config.type;
+    getStakedBalanceForChain: (
+      addresses: string[],
+      networkClientId?: NetworkClientId,
+    ) => {
+      const assetsContractController = getAssetsContractController();
+      return assetsContractController.getStakedBalanceForChain(
+        addresses,
+        networkClientId,
+      );
+    },
+    includeStakedAssets: false,
+    allowExternalServices: () => {
+      const { useExternalServices } = initMessenger.call(
+        'PreferencesController:getState',
+      );
+      return useExternalServices;
     },
     accountsApiChainIds: () => {
       const state = initMessenger.call('RemoteFeatureFlagController:getState');
@@ -59,14 +42,10 @@ export const AccountTrackerControllerInit: ControllerInitFunction<
         state?.remoteFeatureFlags?.assetsAccountApiBalances;
 
       return Array.isArray(featureFlagForAccountApiBalances)
-        ? (featureFlagForAccountApiBalances as string[])
+        ? (featureFlagForAccountApiBalances as `0x${string}`[])
         : [];
     },
-  });
-
-  // Ensure `AccountTrackerController` updates balances after network change.
-  initMessenger.subscribe('NetworkController:networkDidChange', () => {
-    controller.updateAccounts();
+    fetchingEnabled: () => onboardingController().state.completedOnboarding,
   });
 
   return {

app/scripts/controller-init/account-tracker-controller-init.ts

@@ -56,7 +56,6 @@ export const TransactionControllerInit: ControllerInitFunction<
     getFlatState,
     getPermittedAccounts,
     getTransactionMetricsRequest,
-    updateAccountBalanceForTransactionNetwork,
     persistedState,
   } = request;
 
@@ -198,7 +197,6 @@ export const TransactionControllerInit: ControllerInitFunction<
   addTransactionControllerListeners(
     initMessenger,
     getTransactionMetricsRequest,
-    updateAccountBalanceForTransactionNetwork,
   );
 
   const api = getApi(controller);
@@ -266,22 +264,9 @@ function getExternalPendingTransactions(
 function addTransactionControllerListeners(
   initMessenger: TransactionControllerInitMessenger,
   getTransactionMetricsRequest: () => TransactionMetricsRequest,
-  updateAccountBalanceForTransactionNetwork: (
-    transactionMeta: TransactionMeta,
-  ) => void,
 ) {
   const transactionMetricsRequest = getTransactionMetricsRequest();
 
-  initMessenger.subscribe(
-    'TransactionController:unapprovedTransactionAdded',
-    updateAccountBalanceForTransactionNetwork,
-  );
-
-  initMessenger.subscribe(
-    'TransactionController:transactionConfirmed',
-    updateAccountBalanceForTransactionNetwork,
-  );
-
   initMessenger.subscribe(
     'TransactionController:postTransactionBalanceUpdated',
     // TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31879

app/scripts/controller-init/confirmations/transaction-controller-init.ts

@@ -13,6 +13,7 @@ import { SmartTransactionsController } from '@metamask/smart-transactions-contro
 import { TransactionController } from '@metamask/transaction-controller';
 import { AccountsController } from '@metamask/accounts-controller';
 import {
+  AccountTrackerController,
   AssetsContractController,
   CurrencyRateController,
   DeFiPositionsController,
@@ -88,7 +89,6 @@ import { NetworkOrderController } from '../controllers/network-order';
 import OAuthService from '../services/oauth/oauth-service';
 import MetaMetricsController from '../controllers/metametrics-controller';
 import { SnapsNameProvider } from '../lib/SnapsNameProvider';
-import AccountTrackerController from '../controllers/account-tracker-controller';
 import { AppStateController } from '../controllers/app-state-controller';
 import { SnapKeyringBuilder } from '../lib/snap-keyring/snap-keyring';
 import { SubscriptionService } from '../services/subscription/subscription-service';
@@ -262,4 +262,5 @@ export type ControllerFlatState = AccountOrderController['state'] &
   TokenRatesController['state'] &
   NftController['state'] &
   NftDetectionController['state'] &
-  NetworkEnablementController['state'];
+  NetworkEnablementController['state'] &
+  AccountTrackerController['state'];