fix: fixed evaluateCohortEligibility call in home page (#37803)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixed evaluateCohortEligibility call in home page just after the
onboarding is completed.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37803?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fixed evaluateCohortEligibility call in home page just
after the onboarding is completed.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Wires `isSignedIn` into Home and only triggers pending Shield cohort
evaluation when the user is signed in.
> 
> - **Home (`ui/pages/home/home.component.js`)**:
> - Gate `evaluateCohortEligibility` call behind `isSignedIn` in
`componentDidUpdate`.
>   - Add `PropTypes.bool` for new prop `isSignedIn`.
> - **Container (`ui/pages/home/home.container.js`)**:
> - Map `state.metamask.isSignedIn` to `isSignedIn` prop passed to
`Home`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c7a6fa6. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Chaitanya Potti <chaitanya.potti@gmail.com>

Author: lwin-kyaw

ui/pages/home/home.component.js

@@ -177,6 +177,7 @@ export default class Home extends PureComponent {
     evaluateCohortEligibility: PropTypes.func,
     pendingShieldCohort: PropTypes.string,
     setPendingShieldCohort: PropTypes.func,
+    isSignedIn: PropTypes.bool,
   };
 
   state = {
@@ -313,6 +314,7 @@ export default class Home extends PureComponent {
       pendingShieldCohort,
       evaluateCohortEligibility,
       setPendingShieldCohort,
+      isSignedIn,
     } = this.props;
 
     const {
@@ -338,8 +340,8 @@ export default class Home extends PureComponent {
       this.checkStatusAndNavigate();
     }
 
-    // Check for pending Shield cohort evaluation
-    if (pendingShieldCohort && evaluateCohortEligibility) {
+    // Check for pending Shield cohort evaluation if user is signed in
+    if (pendingShieldCohort && evaluateCohortEligibility && isSignedIn) {
       setPendingShieldCohort(null);
       evaluateCohortEligibility(pendingShieldCohort);
     }

ui/pages/home/home.container.js

@@ -196,6 +196,7 @@ const mapStateToProps = (state) => {
     showShieldEntryModal: getShowShieldEntryModal(state),
     isSocialLoginFlow: getIsSocialLoginFlow(state),
     pendingShieldCohort: getPendingShieldCohort(state),
+    isSignedIn: state.metamask.isSignedIn,
   };
 };