-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: fixed evaluateCohortEligibility call in home page #37803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +5 -2)
|
Builds ready [d28f9db]
UI Startup Metrics (1133 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [8e309bd]
UI Startup Metrics (1197 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [05ca2de]
UI Startup Metrics (1212 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [87cd713]
UI Startup Metrics (1224 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [c7a6fa6]
UI Startup Metrics (1198 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR fixed evaluateCohortEligibility call in home page just after the onboarding is completed.
Changelog
CHANGELOG entry: fixed evaluateCohortEligibility call in home page just after the onboarding is completed.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Wires
isSignedIninto Home and only triggers pending Shield cohort evaluation when the user is signed in.ui/pages/home/home.component.js):evaluateCohortEligibilitycall behindisSignedInincomponentDidUpdate.PropTypes.boolfor new propisSignedIn.ui/pages/home/home.container.js):state.metamask.isSignedIntoisSignedInprop passed toHome.Written by Cursor Bugbot for commit c7a6fa6. This will update automatically on new commits. Configure here.