Avoid generating MetaMetrics ID if it doens't already exist

MetaMask · May 29, 2024 · c90863b · c90863b
1 parent 78ec096
commit c90863b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/scripts/controllers/metametrics-data-deletion/metametrics-data-deletion.ts b/app/scripts/controllers/metametrics-data-deletion/metametrics-data-deletion.ts
@@ -104,7 +104,7 @@ export default class MetaMetricsDataDeletionController extends BaseController<
 > {
   #dataDeletionService: DataDeletionService;
 
-  #getMetaMetricsId: () => string;
+  #getMetaMetricsId: () => string | null;
 
   /**
    * Creates a MetaMetricsDataDeletionController instance.
@@ -124,7 +124,7 @@ export default class MetaMetricsDataDeletionController extends BaseController<
     dataDeletionService: DataDeletionService;
     messenger: MetaMetricsDataDeletionControllerMessenger;
     state?: MetaMetricsDataDeletionState;
-    getMetaMetricsId: () => string;
+    getMetaMetricsId: () => string | null;
   }) {
     // Call the constructor of BaseControllerV2
     super({

diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -758,7 +758,8 @@ export default class MetamaskController extends EventEmitter {
         dataDeletionService,
         messenger: metaMetricsDataDeletionMessenger,
         state: initState.metaMetricsDataDeletionController,
-        getMetaMetricsId: () => this.metaMetricsController.getMetaMetricsId(),
+        getMetaMetricsId: () =>
+          this.metaMetricsController.store.getState().metaMetricsId,
       });
 
     const gasFeeMessenger = this.controllerMessenger.getRestricted({