Skip to content

Commit fef9144

Browse files
ccharlyccharly
authored
chore: bump eth-snap-keyring (to enable notify:accountCreated idempotency) cp-13.11.0 (#38292)
## **Description** Bumping `@metamask/eth-snap-keyring` to enable `notify:accountCreated` idempotency which is required by the Bitcoin Snap. This will reduce the number of "misaligned" warnings we had with Bitcoin. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38292?quickstart=1) ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - #38313 ## **Manual testing steps** 1. Onboard with an SRP that has a lot of created accounts (or synced accounts with "Backup & Sync"), I used 50 accounts at least 2. Check the console, you should not see any warning regarding the Bitcoin Snap and misalignment for multichain accounts ## **Screenshots/Recordings** ### **Before** <img width="1516" height="1026" alt="Screenshot 2025-11-26 at 10 30 15" src="https://github.com/user-attachments/assets/51351605-045c-4f4c-bbc6-b07cc1ba8f69" /> <img width="1524" height="1246" alt="Screenshot 2025-11-26 at 10 30 35" src="https://github.com/user-attachments/assets/62b085ec-f488-4753-9055-801ed4c65dbb" /> ### **After** <img width="1514" height="1137" alt="Screenshot 2025-11-26 at 10 27 08" src="https://github.com/user-attachments/assets/b7317c24-231c-4606-b548-954ea1d3978a" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 595ea63 commit fef9144

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@
301301
"@metamask/eth-ledger-bridge-keyring": "11.1.2",
302302
"@metamask/eth-qr-keyring": "^1.1.0",
303303
"@metamask/eth-sig-util": "^8.2.0",
304-
"@metamask/eth-snap-keyring": "^18.0.0",
304+
"@metamask/eth-snap-keyring": "^18.0.2",
305305
"@metamask/eth-token-tracker": "^10.0.2",
306306
"@metamask/eth-trezor-keyring": "^9.0.0",
307307
"@metamask/etherscan-link": "^3.0.0",

‎yarn.lock‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -6478,25 +6478,25 @@ __metadata:
64786478
languageName: node
64796479
linkType: hard
64806480

6481-
"@metamask/eth-snap-keyring@npm:^18.0.0":
6482-
version: 18.0.0
6483-
resolution: "@metamask/eth-snap-keyring@npm:18.0.0"
6481+
"@metamask/eth-snap-keyring@npm:^18.0.0, @metamask/eth-snap-keyring@npm:^18.0.2":
6482+
version: 18.0.2
6483+
resolution: "@metamask/eth-snap-keyring@npm:18.0.2"
64846484
dependencies:
64856485
"@ethereumjs/tx": "npm:^5.4.0"
64866486
"@metamask/eth-sig-util": "npm:^8.2.0"
6487-
"@metamask/keyring-api": "npm:^21.1.0"
6488-
"@metamask/keyring-internal-api": "npm:^9.1.0"
6489-
"@metamask/keyring-internal-snap-client": "npm:^8.0.0"
6490-
"@metamask/keyring-snap-sdk": "npm:^7.1.0"
6487+
"@metamask/keyring-api": "npm:^21.2.0"
6488+
"@metamask/keyring-internal-api": "npm:^9.1.1"
6489+
"@metamask/keyring-internal-snap-client": "npm:^8.0.1"
6490+
"@metamask/keyring-snap-sdk": "npm:^7.1.1"
64916491
"@metamask/keyring-utils": "npm:^3.1.0"
64926492
"@metamask/messenger": "npm:^0.3.0"
64936493
"@metamask/superstruct": "npm:^3.1.0"
64946494
"@metamask/utils": "npm:^11.1.0"
64956495
"@types/uuid": "npm:^9.0.8"
64966496
uuid: "npm:^9.0.1"
64976497
peerDependencies:
6498-
"@metamask/keyring-api": ^21.1.0
6499-
checksum: 10/39a6380e351997e53776c8db9d1558769517a1a12ec1431c40cedb516d90ae447a81b7b1c21bc8d8ffcbc31188cf52f17057a1416d509013cfe8b2f46b314e02
6498+
"@metamask/keyring-api": ^21.2.0
6499+
checksum: 10/2c37e55cf4b56089fb5a081d3809b9004b8bbe2822267fbe5b8884cd687da4a43e122b053ebbc418173353232066a4763edc90002f51ce55a84e53a7009c16e6
65006500
languageName: node
65016501
linkType: hard
65026502

@@ -7014,7 +7014,7 @@ __metadata:
70147014
languageName: node
70157015
linkType: hard
70167016

7017-
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.1.0, @metamask/keyring-api@npm:^21.2.0":
7017+
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.2.0":
70187018
version: 21.2.0
70197019
resolution: "@metamask/keyring-api@npm:21.2.0"
70207020
dependencies:
@@ -7065,27 +7065,27 @@ __metadata:
70657065
languageName: node
70667066
linkType: hard
70677067

7068-
"@metamask/keyring-internal-api@npm:^9.0.0, @metamask/keyring-internal-api@npm:^9.1.0":
7069-
version: 9.1.0
7070-
resolution: "@metamask/keyring-internal-api@npm:9.1.0"
7068+
"@metamask/keyring-internal-api@npm:^9.0.0, @metamask/keyring-internal-api@npm:^9.1.0, @metamask/keyring-internal-api@npm:^9.1.1":
7069+
version: 9.1.1
7070+
resolution: "@metamask/keyring-internal-api@npm:9.1.1"
70717071
dependencies:
7072-
"@metamask/keyring-api": "npm:^21.1.0"
7072+
"@metamask/keyring-api": "npm:^21.2.0"
70737073
"@metamask/keyring-utils": "npm:^3.1.0"
70747074
"@metamask/superstruct": "npm:^3.1.0"
7075-
checksum: 10/6b19f35f57bc1b5dc73957d7f3185236780c93e6292678e22d84f9eb2fe92e15a98437a9bc4fbe5e5e10143d4db36afa2c420636f2cca4bd984e8455ca4332c6
7075+
checksum: 10/ab0fb8e153a02d3d0acf739d77356a1c60e0a7bf998dcbba9468f9f231605beaed472d8bff27dc56323d0a2529167336499e23dcad911fa8c3e37999ed14d2d1
70767076
languageName: node
70777077
linkType: hard
70787078

7079-
"@metamask/keyring-internal-snap-client@npm:^8.0.0":
7080-
version: 8.0.0
7081-
resolution: "@metamask/keyring-internal-snap-client@npm:8.0.0"
7079+
"@metamask/keyring-internal-snap-client@npm:^8.0.0, @metamask/keyring-internal-snap-client@npm:^8.0.1":
7080+
version: 8.0.1
7081+
resolution: "@metamask/keyring-internal-snap-client@npm:8.0.1"
70827082
dependencies:
7083-
"@metamask/keyring-api": "npm:^21.1.0"
7084-
"@metamask/keyring-internal-api": "npm:^9.1.0"
7085-
"@metamask/keyring-snap-client": "npm:^8.1.0"
7083+
"@metamask/keyring-api": "npm:^21.2.0"
7084+
"@metamask/keyring-internal-api": "npm:^9.1.1"
7085+
"@metamask/keyring-snap-client": "npm:^8.1.1"
70867086
"@metamask/keyring-utils": "npm:^3.1.0"
70877087
"@metamask/messenger": "npm:^0.3.0"
7088-
checksum: 10/7a4aa08ac6ac1bda064182420af01b785aaaff37068d14577007ce40e53f4da33b3bbc1a18625ebd75cee6d08c34de8dc860e6c927477335d5f1df72328b563a
7088+
checksum: 10/40a686cd3d1f49accde83bb2a983ac9e897498e1de5a0ccb0768e382d44dd4c273230db95bcd6eace4ad8a184e7ab4fc780770f617994a2ca29b4302890f31b6
70897089
languageName: node
70907090
linkType: hard
70917091

@@ -7105,35 +7105,35 @@ __metadata:
71057105
languageName: node
71067106
linkType: hard
71077107

7108-
"@metamask/keyring-snap-client@npm:^8.0.0, @metamask/keyring-snap-client@npm:^8.1.0":
7109-
version: 8.1.0
7110-
resolution: "@metamask/keyring-snap-client@npm:8.1.0"
7108+
"@metamask/keyring-snap-client@npm:^8.0.0, @metamask/keyring-snap-client@npm:^8.1.0, @metamask/keyring-snap-client@npm:^8.1.1":
7109+
version: 8.1.1
7110+
resolution: "@metamask/keyring-snap-client@npm:8.1.1"
71117111
dependencies:
7112-
"@metamask/keyring-api": "npm:^21.1.0"
7112+
"@metamask/keyring-api": "npm:^21.2.0"
71137113
"@metamask/keyring-utils": "npm:^3.1.0"
71147114
"@metamask/superstruct": "npm:^3.1.0"
71157115
"@types/uuid": "npm:^9.0.8"
71167116
uuid: "npm:^9.0.1"
71177117
webextension-polyfill: "npm:^0.12.0"
71187118
peerDependencies:
71197119
"@metamask/providers": ^19.0.0
7120-
checksum: 10/e92aa7f6e1454150870e8e0a6d9cf4fac7bbc22280d85a252ca7ee428842dfbaaaccae78dfc5ad773e21d757febfcbe6933a72b966c4478f1a2b3fc0088419a1
7120+
checksum: 10/dcdc9a286137a4ae884b709e565b988fb2e555a8a80db5d2ed3e93ee5262c81567a4efac6ff663b6751caf5b1173f92bc8437a395696058018a3b6e93fc30b35
71217121
languageName: node
71227122
linkType: hard
71237123

7124-
"@metamask/keyring-snap-sdk@npm:^7.1.0":
7125-
version: 7.1.0
7126-
resolution: "@metamask/keyring-snap-sdk@npm:7.1.0"
7124+
"@metamask/keyring-snap-sdk@npm:^7.1.1":
7125+
version: 7.1.1
7126+
resolution: "@metamask/keyring-snap-sdk@npm:7.1.1"
71277127
dependencies:
71287128
"@metamask/keyring-utils": "npm:^3.1.0"
71297129
"@metamask/snaps-sdk": "npm:^9.0.0"
71307130
"@metamask/superstruct": "npm:^3.1.0"
71317131
"@metamask/utils": "npm:^11.1.0"
71327132
webextension-polyfill: "npm:^0.12.0"
71337133
peerDependencies:
7134-
"@metamask/keyring-api": ^21.1.0
7134+
"@metamask/keyring-api": ^21.2.0
71357135
"@metamask/providers": ^19.0.0
7136-
checksum: 10/1a1809733c1f21af87f3491d292c499c5441afa0780e848718ec2b6aff50d76bb03ea44ee93ecaa80d79453a98926d84cd13ff406256ab6a2136d9e31250faa8
7136+
checksum: 10/ac4ce050f4647096ef66ebd04d99d1423c002ca0fb05bd83e11caec59754b56d73bb8a95ac3a76f64472713256205e889d6785003dfe2c35f5f1d67c2f2efd12
71377137
languageName: node
71387138
linkType: hard
71397139

@@ -32650,7 +32650,7 @@ __metadata:
3265032650
"@metamask/eth-ledger-bridge-keyring": "npm:11.1.2"
3265132651
"@metamask/eth-qr-keyring": "npm:^1.1.0"
3265232652
"@metamask/eth-sig-util": "npm:^8.2.0"
32653-
"@metamask/eth-snap-keyring": "npm:^18.0.0"
32653+
"@metamask/eth-snap-keyring": "npm:^18.0.2"
3265432654
"@metamask/eth-token-tracker": "npm:^10.0.2"
3265532655
"@metamask/eth-trezor-keyring": "npm:^9.0.0"
3265632656
"@metamask/etherscan-link": "npm:^3.0.0"

0 commit comments

Comments
 (0)