[Bug]: Error: Unable to align accounts with provider "Bitcoin"

[ccharly]

Describe the bug

When onboarding with an SRP that have a lot of accounts synced with Backup & Sync, the Bitcoin Snap usually fails to "align" its accounts and fails with an error at some point. Here 21 times for 50 accounts.

The main reason being that the Snap keyring account creations is not idempotent and the Bitcoin Snap has been designed to use this behavior.

The Snap keyring needs to be updated to support this, thus, avoiding having the Bitcoin Snap to fail during alignments.

Snap keyring fix can be found here:

• fix: make SnapKeyring :accountCreated idempotent accounts#399

Expected behavior

The Bitcoin Snap should be able to align accounts with no error.

Screenshots/Recordings

Steps to reproduce

1. Onboard with a new SRP
2. Creates at least 50 accounts for that SRP

• Make sure to have "Backup & Sync" enabled!

3. Uninstall
4. Re-install
5. Onboard with the same SRP + Inspect your console logs

You should see A LOT of Error: Unable to align accounts with provider "Bitcoin" errors.

Error messages or log output

sentry.ts:24 Error: Unable to align accounts with provider "Bitcoin"
Caused by: JsonRpcError: An unexpected error occurred
captureException	@	sentry.ts:24
delegatedActionHandler	@	Messenger.cjs:340
delegatedActionHandler	@	Messenger.cjs:340
call	@	Messenger.cjs:166
(anonymous)	@	MultichainAccountGroup.cjs:202

Detection stage

During release testing

Version

13.11.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

• Users with a lot of accounts might see those errors during onboarding
• Those errors are generally reported to Sentry (which adds a lot of noise)