Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

personal_sign - render message to sign as utf8 #1173

Closed
kumavis opened this issue Mar 6, 2017 · 0 comments
Closed

personal_sign - render message to sign as utf8 #1173

kumavis opened this issue Mar 6, 2017 · 0 comments
Assignees
@danfinlay @kumavis
Labels
type-enhancement

Comments

@kumavis
Copy link
Member

kumavis commented Mar 6, 2017 •
edited by danfinlay
Loading

No description provided.

@kumavis kumavis modified the milestone: Core Maintenance Mar 6, 2017
@danfinlay danfinlay added this to the Core Maintenance milestone Mar 6, 2017
@danfinlay danfinlay added the ready label Mar 6, 2017
@kumavis kumavis modified the milestones: Core Maintenance, Publish 3.4.x Mar 6, 2017
@danfinlay danfinlay self-assigned this Mar 6, 2017
danfinlay added a commit that referenced this issue Mar 6, 2017
@danfinlay
Render personal_sign messages as utf-8 text
9bd8c5f 
Calls to `personal_sign` are now:

- When hex encoded, preserved as hex encoded, but displayed as utf-8 text.
- When not hex encoded, decoded as utf-8 text as hex for signing.
- The messages proposed for signing are displayed as UTF-8 text.
- When the message cannot be rendered as UTF-8 text, it is displayed as hexadecimal.

Fixes #1173
@danfinlay danfinlay mentioned this issue Mar 6, 2017
Merged
@ghost ghost removed the in progress label Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danfinlay danfinlay

@kumavis kumavis

Labels
type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danfinlay @kumavis @2-am-zzz