Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: uint256 field being rendered as address in signTypedData_v4 #17711

Closed
bschorchit opened this issue Feb 10, 2023 · 1 comment · Fixed by #17846
Closed

[Bug]: uint256 field being rendered as address in signTypedData_v4 #17711

bschorchit opened this issue Feb 10, 2023 · 1 comment · Fixed by #17846
Labels
area-signatures Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@bschorchit
Copy link

This was reported by OpenSea here.

It seems that if their "counter" field is a uint256 but if it's exactly 20 bytes it formats/shows as an address. The correct behavior would be to only render it as an address if that parameter is of type address.

Screenshots

Screenshot 2023-02-09 at 6 39 05 PM

Screenshot 2023-02-09 at 6 39 05 PM
@bschorchit bschorchit added PS-team PS MM extension team issues team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead area-signatures type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. labels Feb 10, 2023
@FrederikBolding FrederikBolding mentioned this issue Feb 21, 2023
Merged
@FrederikBolding
Copy link
Member

I opened a PR that fixes this, #17846

@bschorchit bschorchit removed the PS-team PS MM extension team issues label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-signatures Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
None yet
Milestone
No milestone
2 participants
@FrederikBolding @bschorchit