-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug where non-address types would be rendered as addresses in EIP-712 #17846
Conversation
Builds ready [4688a99]
Page Load Metrics (1813 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
}, | ||
}; | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey are test cases below no longer relevant ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were seemingly misunderstandings of what data the component should show, so I removed them because they would fail now that I changed the component input to be valid too 😅
Explanation
Adds type annotation to sanitized EIP-712 messages such that the type annotation can be used for selecting how to display data.
This also fixes #17711