Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where non-address types would be rendered as addresses in EIP-712 #17846

Merged
merged 6 commits into from
Feb 27, 2023

Conversation

FrederikBolding
Copy link
Member

Explanation

Adds type annotation to sanitized EIP-712 messages such that the type annotation can be used for selecting how to display data.

This also fixes #17711

@FrederikBolding FrederikBolding requested a review from a team as a code owner February 21, 2023 15:07
@metamaskbot
Copy link
Collaborator

Builds ready [4688a99]
Page Load Metrics (1813 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1033181434521
domContentLoaded14782147176315675
load14782147181317383
domInteractive14782147176315675
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 36 bytes
  • common: 43 bytes

},
};
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey are test cases below no longer relevant ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were seemingly misunderstandings of what data the component should show, so I removed them because they would fail now that I changed the component input to be valid too 😅

@FrederikBolding FrederikBolding merged commit 64bfe6f into develop Feb 27, 2023
@FrederikBolding FrederikBolding deleted the fb/fix-eip712-rendering-bug branch February 27, 2023 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: uint256 field being rendered as address in signTypedData_v4
4 participants