Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate price conversion preference to infura API #2240

Closed
1 of 2 tasks
kumavis opened this issue Sep 30, 2017 · 4 comments
Closed
1 of 2 tasks

Migrate price conversion preference to infura API #2240

kumavis opened this issue Sep 30, 2017 · 4 comments
Labels
area-background Issues relating to the extension background process. type-bug

Comments

@kumavis
Copy link
Member

kumavis commented Sep 30, 2017 •
edited by 2-am-zzz
Loading

  • change to lower case
  • make sure the selected option is available in our options, otherwise default to USD
@kumavis
Copy link
Member Author

kumavis commented Sep 30, 2017

maybe @Zanibas or @tmashuang

@kumavis kumavis added area-background Issues relating to the extension background process. type-bug labels Sep 30, 2017
@kumavis
Copy link
Member Author

kumavis commented Sep 30, 2017

AFAIK, currency conversion is broken for all active users unless they got and re-select their currency

@danfinlay
Copy link
Contributor

Maurcy even warned us about the first one: #2177 (comment)

danfinlay added a commit that referenced this issue Sep 30, 2017
@danfinlay
Version 3.10.8 - Fix Currency Conversion
d5b0d8a 
In our conversion to the new Infura API, somehow we were sending upper-cased conversions to their lower-case sensitive API.

Fixes the first part of #2240
@danfinlay
Copy link
Contributor

I'm going to do the first one immediately, I hope someone will pick up the 2nd part soon.

@danfinlay danfinlay mentioned this issue Sep 30, 2017
Merged
@2-am-zzz 2-am-zzz self-assigned this Oct 2, 2017
@2-am-zzz 2-am-zzz added P2-sooner and removed P1-asap labels Oct 2, 2017
@kumavis kumavis added P3-soon and removed P2-sooner labels Oct 2, 2017
@2-am-zzz 2-am-zzz removed their assignment Feb 26, 2018
@joeytwiddle joeytwiddle mentioned this issue Aug 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-background Issues relating to the extension background process. type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danfinlay @bdresser @kumavis @2-am-zzz