Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AccountTracker (implementation + tests) to TypeScript #25928

Closed
1 of 9 tasks
mcmire opened this issue Jul 18, 2024 · 0 comments · Fixed by #27231
Closed
1 of 9 tasks

Convert AccountTracker (implementation + tests) to TypeScript #25928

mcmire opened this issue Jul 18, 2024 · 0 comments · Fixed by #27231
Assignees
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Jul 18, 2024

What is this about?

As a prerequisite for migrating AccountTracker to BaseController v2, and to support the TypeScript migration effort for the extension, we want to convert AccountTracker to TypeScript.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

  • All functions and methods are annotated with argument and return types.
  • All properties and free variables are annotated with types.
  • # is used for private properties and methods instead of _.
  • The test file is converted to TypeScript along with the implementation file.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-framework
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants