Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert account tracker to typescript #27231

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Sep 17, 2024

Description

Convert AccountTracker (implementation + tests) to TypeScript

Open in GitHub Codespaces

Related issues

Fixes: #25928

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner September 17, 2024 22:04
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the feature/convert-account-tracker-to-typescript branch 6 times, most recently from 4d56847 to c85633a Compare September 17, 2024 22:37
@cryptodev-2s cryptodev-2s force-pushed the feature/convert-account-tracker-to-typescript branch from c85633a to 1b07a49 Compare September 17, 2024 22:38
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [1b07a49]
Page Load Metrics (1629 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19422021494420201
domContentLoaded14582016159613263
load14662104162914570
domInteractive13170454421
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 831 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (bc7929b) to head (1b07a49).

Files with missing lines Patch % Lines
app/scripts/lib/account-tracker.ts 75.86% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #27231      +/-   ##
===========================================
- Coverage    70.02%   69.99%   -0.03%     
===========================================
  Files         1443     1443              
  Lines        50164    50172       +8     
  Branches     14039    14046       +7     
===========================================
- Hits         35126    35115      -11     
- Misses       15038    15057      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f47e2cd]
Page Load Metrics (1744 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148524421753239115
domContentLoaded147822531718213102
load148623391744222107
domInteractive1495392010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 831 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [49410d3]
Page Load Metrics (1812 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33822331643446214
domContentLoaded16062392178918388
load16142411181219192
domInteractive147741178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 831 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s merged commit 0de7915 into develop Sep 30, 2024
76 of 77 checks passed
@cryptodev-2s cryptodev-2s deleted the feature/convert-account-tracker-to-typescript branch September 30, 2024 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Convert AccountTracker (implementation + tests) to TypeScript
4 participants