feat: Migrate AccountTrackerController to BaseController v2 #27258

cryptodev-2s · 2024-09-18T15:25:40Z

Description

Migrate AccountTrackerController to BaseController v2

PS: Should be merged after the conversion to typescript is merged #27231

Related issues

Fixes: #25929

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-18T15:25:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-30T22:43:12Z

Builds ready [d54670c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1866 ± 151 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	262	2773	1775	443	213
		domContentLoaded	1531	2366	1799	200	96
		load	1539	2954	1866	314	151
		domInteractive	15	101	51	22	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 165 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

app/scripts/controllers/account-tracker-controller.ts

…r-to-bc2

metamaskbot · 2024-10-02T11:22:15Z

Builds ready [0e88e31]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1752 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1489	2191	1755	186	89
		domContentLoaded	1482	2162	1725	185	89
		load	1490	2193	1752	183	88
		domInteractive	18	73	35	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 165 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

MajorLift · 2024-10-03T18:35:03Z

The sonarcloud quality gate warning is non-blocking for now, but that will change soon, and then someone will be stuck having to make up the coverage for the changes in the PR.

In this case I guess this isn't too problematic since we expect to remove the extension controller entirely.

MajorLift

Great work as always!

app/scripts/controllers/account-tracker-controller.ts

…r-to-bc2

NiranjanaBinoy

LGTM

metamaskbot · 2024-10-03T21:44:32Z

Builds ready [092a237]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1993 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	242	2269	1659	694	333
		domContentLoaded	1655	2252	1958	130	62
		load	1665	2282	1993	137	66
		domInteractive	28	178	57	32	15

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 165 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…r-to-bc2

metamaskbot · 2024-10-04T13:48:15Z

Builds ready [41139d2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2022 ± 120 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	243	2713	1688	707	340
		domContentLoaded	1612	2504	1984	225	108
		load	1615	2685	2022	249	120
		domInteractive	16	112	42	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 165 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…r-to-bc2

sonarqubecloud · 2024-10-04T14:39:14Z

Quality Gate failed

Failed conditions
76.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

metamaskbot · 2024-10-04T15:00:08Z

Builds ready [d42e196]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2163 ± 199 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	157	3277	1567	929	446
		domContentLoaded	1569	3221	2135	404	194
		load	1577	3286	2163	414	199
		domInteractive	19	78	52	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 165 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

cryptodev-2s requested review from kumavis and a team as code owners September 18, 2024 15:25

github-actions bot added the team-wallet-framework label Sep 18, 2024

cryptodev-2s force-pushed the feature/migrate-account-tracker-controller-to-bc2 branch from 945021d to 25d5df8 Compare September 18, 2024 15:29

cryptodev-2s requested a review from a team September 18, 2024 15:29

cryptodev-2s force-pushed the feature/migrate-account-tracker-controller-to-bc2 branch 2 times, most recently from 33bf4f0 to 16a5b92 Compare September 18, 2024 16:34

cryptodev-2s added the DO-NOT-MERGE Pull requests that should not be merged label Sep 18, 2024

desi linked an issue Sep 19, 2024 that may be closed by this pull request

Migrate AccountTrackerController to BaseController v2 #25929

Closed

9 tasks

desi assigned cryptodev-2s Sep 23, 2024

cryptodev-2s force-pushed the feature/migrate-account-tracker-controller-to-bc2 branch from 16a5b92 to a29147e Compare September 29, 2024 17:25

cryptodev-2s mentioned this pull request Sep 30, 2024

feat: convert account tracker to typescript #27231

Merged

7 tasks

Base automatically changed from feature/convert-account-tracker-to-typescript to develop September 30, 2024 20:39

cryptodev-2s added 2 commits September 30, 2024 22:43

feat: Migrate AccountTrackerController to BaseController v2

abfce99

fix: use type guard predicate instead of type assertion

3b5a990

cryptodev-2s force-pushed the feature/migrate-account-tracker-controller-to-bc2 branch from a29147e to 3b5a990 Compare September 30, 2024 20:47

cryptodev-2s removed the DO-NOT-MERGE Pull requests that should not be merged label Sep 30, 2024

cryptodev-2s added 2 commits September 30, 2024 23:07

fix: lint issues

1490a3b

fix: e2e tests

d54670c

MajorLift reviewed Oct 1, 2024

View reviewed changes

app/scripts/controllers/account-tracker-controller.ts Show resolved Hide resolved

MajorLift reviewed Oct 1, 2024

View reviewed changes

app/scripts/controllers/account-tracker-controller.ts Show resolved Hide resolved

kanthesha reviewed Oct 2, 2024

View reviewed changes

app/scripts/controllers/account-tracker-controller.ts Outdated Show resolved Hide resolved

cryptodev-2s and others added 2 commits October 2, 2024 12:47

Merge branch 'develop' into feature/migrate-account-tracker-controlle…

d357043

…r-to-bc2

fix: sentry

0e88e31

cryptodev-2s requested a review from kanthesha October 2, 2024 11:02

MajorLift previously approved these changes Oct 3, 2024

View reviewed changes

NiranjanaBinoy reviewed Oct 3, 2024

View reviewed changes

app/scripts/controllers/account-tracker-controller.ts Show resolved Hide resolved

fix: add jsdoc for getCurrentChaindId

7b41586

cryptodev-2s dismissed MajorLift’s stale review via 7b41586 October 3, 2024 21:12

cryptodev-2s requested a review from NiranjanaBinoy October 3, 2024 21:13

Merge branch 'develop' into feature/migrate-account-tracker-controlle…

092a237

…r-to-bc2

NiranjanaBinoy approved these changes Oct 3, 2024

View reviewed changes

cryptodev-2s requested a review from MajorLift October 4, 2024 12:43

Merge branch 'develop' into feature/migrate-account-tracker-controlle…

41139d2

…r-to-bc2

MajorLift approved these changes Oct 4, 2024

View reviewed changes

cryptodev-2s added this pull request to the merge queue Oct 4, 2024

cryptodev-2s removed this pull request from the merge queue due to a manual request Oct 4, 2024

Merge branch 'develop' into feature/migrate-account-tracker-controlle…

d42e196

…r-to-bc2

cryptodev-2s added this pull request to the merge queue Oct 4, 2024

Merged via the queue into develop with commit 5790f85 Oct 4, 2024
76 of 77 checks passed

cryptodev-2s deleted the feature/migrate-account-tracker-controller-to-bc2 branch October 4, 2024 15:17

github-actions bot locked and limited conversation to collaborators Oct 4, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 4, 2024

gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migrate AccountTrackerController to BaseController v2 #27258

feat: Migrate AccountTrackerController to BaseController v2 #27258

cryptodev-2s commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024

metamaskbot commented Sep 30, 2024

metamaskbot commented Oct 2, 2024

MajorLift commented Oct 3, 2024

MajorLift left a comment

NiranjanaBinoy left a comment

metamaskbot commented Oct 3, 2024

metamaskbot commented Oct 4, 2024

sonarqubecloud bot commented Oct 4, 2024

metamaskbot commented Oct 4, 2024

feat: Migrate AccountTrackerController to BaseController v2 #27258

feat: Migrate AccountTrackerController to BaseController v2 #27258

Conversation

cryptodev-2s commented Sep 18, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 18, 2024

metamaskbot commented Sep 30, 2024

metamaskbot commented Oct 2, 2024

MajorLift commented Oct 3, 2024

MajorLift left a comment

Choose a reason for hiding this comment

NiranjanaBinoy left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 3, 2024

metamaskbot commented Oct 4, 2024

sonarqubecloud bot commented Oct 4, 2024

Quality Gate failed

metamaskbot commented Oct 4, 2024

cryptodev-2s commented Sep 18, 2024 •

edited

Loading