-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Cannot convert undefined or null to object #26243
Comments
Additional information: reproducible on all networks, not just BSC. |
Thanks @egorFiNE I have attempted to reproduce this but am not able to. Attached is a video of a successful send of USDT, using version 12 of metamask. Am I following the same steps that you are following? usdt-send-v12.mp4 |
@danjm I have just recorded a video with the bug reproduction. Can I send it to you by email? |
Hey, actually, I think I reproduced it now. Can you check if the "Show balance and token price checker" toggle in your Settings is off? If so, I think that is required to reproduce this bug. If you are okay with having that setting turned on, then you can fix the bug by turning the "Show balance and token price checker" setting on, switching networks and then switching back to your desired network. If you do not want to use MetaMask with that setting turned on, then you will have to wait for us to publish a bug fix. In any case, please do confirm that setting is toggled off, as it will confirm my understanding of the bug. Thanks again for reporting this and for your help, and sorry for the inconvenience of this bug. |
@danjm yeah, that's it. Toggled it on and it works now. |
## **Description** Fixes an issue when `Show balance and token price checker` is turned off in settings, certain actions like sending, importing, or swapping a token crash metamask. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26264?quickstart=1) ## **Related issues** Fixes: #26243 ## **Manual testing steps** 1. Go into settings > security and privacy 2. Turn off `Show balance and token price checker` 3. Switch chains 4. Click import tokens on the tokens tab. Modal should popup without error 5. Click swap and enter tokens + amount. Swap rate should fetch successfully. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Fixes an issue when `Show balance and token price checker` is turned off in settings, certain actions like sending, importing, or swapping a token crash metamask. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26264?quickstart=1) Fixes: #26243 1. Go into settings > security and privacy 2. Turn off `Show balance and token price checker` 3. Switch chains 4. Click import tokens on the tokens tab. Modal should popup without error 5. Click swap and enter tokens + amount. Swap rate should fetch successfully. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Fixes an issue when `Show balance and token price checker` is turned off in settings, certain actions like sending, importing, or swapping a token crash metamask. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26264?quickstart=1) ## **Related issues** Fixes: #26243 ## **Manual testing steps** 1. Go into settings > security and privacy 2. Turn off `Show balance and token price checker` 3. Switch chains 4. Click import tokens on the tokens tab. Modal should popup without error 5. Click swap and enter tokens + amount. Swap rate should fetch successfully. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Describe the bug
Sending USDT on BSC to an address crashes MetaMask and makes it unusable even after the restart. I have sent USDT countless times on BSC before so that's a regression of v12.
The way to reset MetaMask is to restart chrome, switch MetaMask to another network, Reset activity, then back to BSC and again Reset activity and only after that I can use MetaMask again.
Bug is 100% repeatable.
Expected behavior
No response
Screenshots/Recordings
Steps to reproduce
Boom,
Cannot convert undefined or null to object
Error messages or log output
The text was updated successfully, but these errors were encountered: