Add unit test for setupPhishingCommunication and setUpCookieHandlerCommunication #27119
Assignees
Labels
regression-main
Regression bug that was found on main branch, but not yet present in production
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-extension-platform
Comments
7 tasks
metamaskbot
added
the
regression-main
Merged
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 24, 2024
…HandlerCommunication (#27736) Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/27736?quickstart=1) ## **Related issues** Fixes: #27119 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27736?quickstart=1){kind=link}
metamaskbot
added
the
release-12.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
setupPhishingCommunication and setUpCookieHandlerCommunication in the metamask-controller need unit tests.
Expected behavior
No response
Screenshots/Recordings
No response
Steps to reproduce
.
Error messages or log output
No response
Detection stage
On the development branch
Version
12.1.2
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: