Fix "Snap Account Signatures and Disconnects can connect to the Test Dapp, then #signTypedDataV3, disconnect then connect, then #signTypedDataV4 (async flow approve)" flaky test #27892
Assignees
Labels
area-qa
Relating to QA work (Quality Assurance)
flaky tests
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-extension-platform
Comments
seaona
added
team-extension-platform
flaky tests
area-qa
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 16, 2024
…to the Test Dapp, then #signTypedDataV3, disconnect then connect, then #signTypedDataV4 (async flow approve)` (#27887) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** After connecting to the test dapp we are automatically switched to Mainnet (this is a recent change, didn't happen before). Then there is a race condition where the network the dapp sees is different from the wallet one, causing a miss-match and making the signature fail never opening the dialog. This seems an issue on the wallet side, as we should preserve the selected network after connecting, as we used to do before. I've opened an issue for that [here](#27891). This just fixes the issue on the e2e side, but it needs to be fixed on the wallet side and remove the extra step again once the issue is fixed. [](https://codespaces.new/MetaMask/metamask-extension/pull/27887?quickstart=1) ## **Related issues** Fixes: #27892 ## **Manual testing steps** 1. Check ci ## **Screenshots/Recordings** See how you are automatically switched to mainnet https://github.com/user-attachments/assets/d8fa53f5-b207-46bc-8e54-073245eff7b7 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27887?quickstart=1){kind=link}
metamaskbot
added
the
release-12.7.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/105739/workflows/fbec5420-f5cb-4d84-8d40-32dd54c74005/jobs/3947381/tests#failed-test-0
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: