Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POM] Migrate onboarding e2e tests to page object modal #27989

Closed
9 tasks
chloeYue opened this issue Oct 21, 2024 · 0 comments
Closed
9 tasks

[POM] Migrate onboarding e2e tests to page object modal #27989

chloeYue opened this issue Oct 21, 2024 · 0 comments
Assignees
@chloeYue
Labels
area-qa Relating to QA work (Quality Assurance) team-extension-platform

Comments

@chloeYue
Copy link
Contributor

What is this about?

Migrate onboarding e2e tests to page object modal

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@chloeYue chloeYue self-assigned this Oct 21, 2024
@chloeYue chloeYue added the area-qa Relating to QA work (Quality Assurance) label Oct 22, 2024
@chloeYue chloeYue mentioned this issue Oct 23, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2024
@devin-ai-integration @chloeYue @seaona
test: [POM] Create onboarding related page object modal base pages an…
639e46f 
…d migrate e2e tests (#28036)

## **Description**
This PR migrates onboarding e2e tests to Page Object Model (POM)
pattern, improving test stability and maintainability.

Changes include:
- Migrate test `test/e2e/tests/onboarding/onboarding.spec.js` to POM
- Migrate test `test/e2e/tests/onboarding/onboarding.spec.js` to
TypeScript
- Created all onboarding-related pages and functions
- Avoided unnecessary delays
- Reduced flakiness 
- I will create follow-up PRs after this one is merged to avoid having a
very big PR.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1)

## **Related issues**

Fixes: ##27989

## **Manual testing steps**
Check code readability, make sure tests pass.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Chloe Gao <chloe.gao@consensys.net>
Co-authored-by: chloeYue <105063779+chloeYue@users.noreply.github.com>
Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
@chloeYue chloeYue mentioned this issue Oct 24, 2024
Merged
7 tasks
cryptotavares pushed a commit that referenced this issue Oct 25, 2024
@devin-ai-integration @chloeYue
@seaona @cryptotavares
test: [POM] Create onboarding related page object modal base pages an…
443cf7b 
…d migrate e2e tests (#28036)

## **Description**
This PR migrates onboarding e2e tests to Page Object Model (POM)
pattern, improving test stability and maintainability.

Changes include:
- Migrate test `test/e2e/tests/onboarding/onboarding.spec.js` to POM
- Migrate test `test/e2e/tests/onboarding/onboarding.spec.js` to
TypeScript
- Created all onboarding-related pages and functions
- Avoided unnecessary delays
- Reduced flakiness 
- I will create follow-up PRs after this one is merged to avoid having a
very big PR.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1)

## **Related issues**

Fixes: ##27989

## **Manual testing steps**
Check code readability, make sure tests pass.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Chloe Gao <chloe.gao@consensys.net>
Co-authored-by: chloeYue <105063779+chloeYue@users.noreply.github.com>
Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloeYue chloeYue

Labels
area-qa Relating to QA work (Quality Assurance) team-extension-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chloeYue