[Bug]: The increment button for the custom nonce field on redesigned confirmations is not functioning as anticipated #28033
Assignees
Labels
regression-RC-12.6.0
Regression bug that was found in release candidate (RC) for release 12.6.0
release-12.9.0
Issue or pull request that will be included in release 12.9.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-confirmations
Push issues to confirmations team
type-bug
Comments
sleepytanya
added
type-bug
team-confirmations
sleepytanya
changed the title
benjisclowder
added
the
Sev2-normal
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 25, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** See original bug ticket. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28659?quickstart=1) ## **Related issues** Fixes: #28033 ## **Manual testing steps** See original bug ticket. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/28659?quickstart=1){kind=link}
metamaskbot
added
the
release-12.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The increment button for the custom nonce field on redesigned confirmations is not functioning as anticipated. Rather than adjusting the nonce value by increments of 1, it defaults to 0 and 1 for decreasing and increasing actions, respectively.
Expected behavior
Screenshots/Recordings
Redesigned transaction request:
new.mov
Legacy transaction request working as expected:
legacy.mov
Steps to reproduce
Advanced SettingsError messages or log output
No response
Detection stage
During release testing
Version
12.6.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: