Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "BTC Account - Overview has balance" flaky test #28182

Closed
9 tasks
seaona opened this issue Oct 30, 2024 · 0 comments · Fixed by #28181
Closed
9 tasks

Fix "BTC Account - Overview has balance" flaky test #28182

seaona opened this issue Oct 30, 2024 · 0 comments · Fixed by #28181
Assignees
@seaona
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-extension-platform

Comments

@seaona
Copy link
Contributor

seaona commented Oct 30, 2024

What is this about?

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/108574/workflows/4249e906-8122-43d4-bf25-81f75ac78497/jobs/4060900/tests#failed-test-0

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@seaona seaona added team-extension-platform flaky tests area-qa Relating to QA work (Quality Assurance) labels Oct 30, 2024
@seaona seaona self-assigned this Oct 30, 2024
@seaona seaona mentioned this issue Oct 30, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@seaona
fix: flaky test BTC Account - Overview has balance (#28181)
5227d6f 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Anti-pattern where we assert the balance BTC balance is 1BTC using
getText. We should rather find the element by the expected balance to
avoid race conditions


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28181?quickstart=1)

## **Related issues**

Fixes: #28182

## **Manual testing steps**

1. Check ci

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seaona seaona

Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky test BTC Account - Overview has balance MetaMask/metamask-extension
2 participants
@metamaskbot @seaona