Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Native Send - Metrics - When I have the redesign toggle disabled I still see Send ETH transactions with redesigned_confirmation in Metrics Events #28322

Closed
seaona opened this issue Nov 6, 2024 · 1 comment · Fixed by #28443
Closed

[Bug]: Native Send - Metrics - When I have the redesign toggle disabled I still see Send ETH transactions with redesigned_confirmation in Metrics Events #28322

seaona opened this issue Nov 6, 2024 · 1 comment · Fixed by #28443
Assignees
@digiwand
Labels
regression-RC-12.7.0 release-12.8.0 Issue or pull request that will be included in release 12.8.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Nov 6, 2024 •
edited
Loading

Describe the bug

When I have the redesign toggle disabled and I send a native token (ie Send ETH) I still see transactions with redesigned_confirmation in Metrics Events, for transactions with the old designs.
This happens for both when the Send is initiated from the wallet or from a dapp.

Expected behavior

We should not see the redesigned_confirmation in the ui_customizations for metrics events, when the redesign is off

Screenshots/Recordings

re-designed-conf-metrics.mp4

Steps to reproduce

  1. Disable transactions redesign
  2. Enable metrics
  3. Trigger a send ETH transaction
  4. See the old design, but the metric event has the redesigned_confirmation

Error messages or log output

No response

Detection stage

During release testing

Version

12.7.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response
@seaona seaona added type-bug Something isn't working team-confirmations Push issues to confirmations team labels Nov 6, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 6, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 6, 2024
@seaona seaona added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Nov 6, 2024
@metamaskbot metamaskbot added the regression-prod-12.7.0 Regression bug that was found in production in release 12.7.0 label Nov 6, 2024
@seaona seaona added regression-RC-12.7.0 release-blocker This bug is blocking the next release and removed regression-prod-12.7.0 Regression bug that was found in production in release 12.7.0 labels Nov 6, 2024
@seaona
Copy link
Contributor Author

seaona commented Nov 6, 2024

ℹ️ : @bschorchit adding the release-blocker tag, as all regressions are considered release-blockers by default. Feel free to remove the label if you want to re-assess the priority

@digiwand digiwand self-assigned this Nov 7, 2024
@sleepytanya sleepytanya mentioned this issue Nov 7, 2024
Closed
@digiwand digiwand mentioned this issue Nov 8, 2024
Closed
7 tasks
@cryptotavares cryptotavares mentioned this issue Nov 13, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
@cryptotavares @vinistevam
fix: ui customizations for redesigned transactions (#28443)
072c8c7 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28443?quickstart=1)

## **Related issues**

Fixes: #28322
Fixes: #28339

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
cryptotavares added a commit that referenced this issue Nov 14, 2024
@cryptotavares @vinistevam
fix: ui customizations for redesigned transactions (#28443)
bee54dd 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28443?quickstart=1)

## **Related issues**

Fixes: #28322
Fixes: #28339

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>
@cryptotavares cryptotavares mentioned this issue Nov 14, 2024
Merged
7 tasks
cryptotavares added a commit that referenced this issue Nov 14, 2024
@cryptotavares @vinistevam
fix: ui customizations for redesigned transactions (#28443) (#28457)
f0d2588 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Cherry pick:
072c8c7

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28443?quickstart=1)

## **Related issues**

Fixes: #28322
Fixes: #28339

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digiwand digiwand

Labels
regression-RC-12.7.0 release-12.8.0 Issue or pull request that will be included in release 12.8.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
3 participants
@digiwand @metamaskbot @seaona