Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Add hide token hides the token when clicked" flaky tests #28664

Closed
hjetpoluru opened this issue Nov 22, 2024 · 1 comment
Closed

Fix "Add hide token hides the token when clicked" flaky tests #28664

hjetpoluru opened this issue Nov 22, 2024 · 1 comment
Assignees
@chloeYue
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@hjetpoluru
Copy link
Contributor

hjetpoluru commented Nov 22, 2024 •
edited
Loading

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/112120/workflows/c7a58fbc-47a8-42ee-98ac-687d37b809dd/jobs/4198264/tests

test-e2e-firefox
Test scenario - Add hide token hides the token when clicked
Test path - /test/e2e/tests/tokens/add-hide-token.spec.js

Expected values to be strictly equal:

1 !== 2

  (Ran on CircleCI Node 23 of 24, Job test-e2e-firefox)
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 2

    at /home/circleci/project/test/e2e/tests/tokens/add-hide-token.spec.js:56:16
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async withFixtures (test/e2e/helpers.js:220:5)
    at async Context.<anonymous> (test/e2e/tests/tokens/add-hide-token.spec.js:16:5)

      + expected - actual

      -1
      +2
@hjetpoluru hjetpoluru added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform flaky tests labels Nov 22, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 22, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 22, 2024
@chloeYue chloeYue self-assigned this Nov 25, 2024
@chloeYue chloeYue mentioned this issue Nov 25, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
@chloeYue
test: [POM] Migrate add token e2e tests to TS and Page Object Model (#…
b6c750d 
…28658)

## **Description**

- Fix flaky test add hide token, the reason of flakiness is a race
condition that we assert number of listed tokens before all tokens are
displayed
- Migrate add token e2e tests to TS and Page Object Model

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1)

## **Related issues**

Fixes: #28681
#28664

## **Manual testing steps**
Check code readability, make sure tests pass.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@chloeYue chloeYue mentioned this issue Nov 28, 2024
Merged
7 tasks
@chloeYue
Copy link
Contributor

Close this issue as fix has been merged in #28658

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloeYue chloeYue

Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Bugs by severity
Archived in project
Bugs by team
Status: Fixed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloeYue @hjetpoluru