Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Extension breaks with an error TypeError: Cannot read properties of undefined (reading 'conversion at LavaPack.loadBundle.n.useTokenFiatAmount when trying to import tokens #28750

Closed
sleepytanya opened this issue Nov 27, 2024 · 1 comment · Fixed by #28753
Assignees
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

The issue described tends to occur when a user possesses assets across different networks, switching between networks and importing tokens.
For me It is most likely to manifest after adding a new network and attempting to import tokens while the 'Current network' option is selected. Although exact reproduction steps are not available and this bug also happened to me while importing token for 'All networks'

Expected behavior

Screenshots/Recordings

errorTokenImport.mov
Screenshot 2024-11-26 at 17 44 05

Steps to reproduce

  1. Have non-imported tokens across different networks
  2. Switch networks, import tokens

Error messages or log output

No response

Detection stage

On the development branch

Version

qa-9

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Nov 27, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 27, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 27, 2024
@sleepytanya sleepytanya changed the title [Bug]: Extension breaks with an error TypeError: Cannot read properties of undefined (reading 'conversion at LavaPack.loadBundle.n.useTokenFiatAmount when trying t import tokens [Bug]: Extension breaks with an error TypeError: Cannot read properties of undefined (reading 'conversion at LavaPack.loadBundle.n.useTokenFiatAmount when trying to import tokens Nov 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
## **Description**

#28750

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28753?quickstart=1)

## **Related issues**

Fixes: #28750

## **Manual testing steps**

Testing steps in issue. Behavior is inconsistent, hard to replicate
consistently.

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
@Unik0rnMaggie
Copy link
Contributor

Not present in the latest develop build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants