Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test setup in SnapUIRenderer re-usable #31292

Open
1 of 9 tasks
hmalik88 opened this issue Mar 25, 2025 · 0 comments · May be fixed by #31361
Open
1 of 9 tasks

Make test setup in SnapUIRenderer re-usable #31292

hmalik88 opened this issue Mar 25, 2025 · 0 comments · May be fixed by #31361
Labels
team-snaps-platform Snaps Platform team

Comments

@hmalik88
Copy link
Contributor

hmalik88 commented Mar 25, 2025 •
edited
Loading

What is this about?

The idea is to move the component specific tests in snap-ui-renderer.test.js to their own files e.g. snap-ui-address-input.test.ts. We need to make the setup code in snap-ui-renderer.test.js re-usable before we can do that.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move Snap component tests into their own files MetaMask/metamask-extension
1 participant
@hmalik88