chore: move Snap component tests into their own files #31361

hmalik88 · 2025-03-27T16:54:16Z

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

What is the reason for the change? snap-ui-renderer.test.js was quickly becoming a mess with all of the snap component tests in there.
What is the improvement/solution? Break the component tests out into their respective files and make the test setup re-usable.

Related issues

Fixes: #31292

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-27T16:54:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-27T17:33:04Z

Builds ready [bbc840e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1099	1486	56	1220	1284
			load	1045	925	1359	57	1359	990
			domContentLoaded	1038	919	1345	56	955	985
			domInteractive	17	13	70	9	15	29
			firstPaint	803	127	1354	383	240	982
			backgroundConnect	10	6	51	6	8	9
			firstReactRender	19	14	52	5	19	30
			getState	10	4	34	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	788	666	1076	55	821	864
			setupStore	7	5	19	2	7	8
	Webpack	Home	uiStartup	934	838	1176	57	959	980
			load	798	604	977	66	841	875
			domContentLoaded	792	594	968	66	836	871
			domInteractive	15	12	40	7	14	36
			firstPaint	442	52	971	332	821	876
			backgroundConnect	15	11	34	5	15	28
			firstReactRender	14	12	24	2	13	16
			getState	6	3	19	2	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	790	584	958	66	835	862
			setupStore	7	5	12	1	8	9
Firefox	Browserify	Home	uiStartup	1421	1219	2037	156	1458	1823
			load	1267	1084	1856	148	1305	1651
			domContentLoaded	1267	1083	1856	148	1304	1651
			domInteractive	115	39	308	39	86	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	83	11	28	52
			firstReactRender	25	20	57	6	26	34
			getState	8	4	51	7	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	1242	1066	1836	147	1285	1624
			setupStore	7	4	39	5	6	7
	Webpack	Home	uiStartup	1004	822	1611	166	906	962
			load	874	711	1410	146	827	945
			domContentLoaded	874	711	1410	146	826	945
			domInteractive	110	35	216	29	155	92
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	97	14	25	61
			firstReactRender	20	16	29	2	20	25
			getState	10	5	75	11	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	857	696	1379	143	833	987
			setupStore	8	5	63	7	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-27T18:28:29Z

Builds ready [63f8c77]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1267 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1267	1131	1459	67	1311	1382
			load	1117	1007	1300	66	1159	1240
			domContentLoaded	1111	1002	1295	66	1153	1234
			domInteractive	18	14	81	10	16	35
			firstPaint	788	136	1302	431	206	280
			backgroundConnect	10	6	30	4	9	10
			firstReactRender	21	15	53	7	21	37
			getState	12	3	39	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	853	739	1029	65	893	966
			setupStore	8	4	17	3	7	8
	Webpack	Home	uiStartup	966	859	1118	54	969	996
			load	821	584	974	66	866	903
			domContentLoaded	815	577	961	66	860	899
			domInteractive	16	12	50	7	14	36
			firstPaint	444	57	903	341	844	893
			backgroundConnect	16	12	32	4	16	26
			firstReactRender	17	12	298	28	14	16
			getState	7	4	14	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	813	566	959	67	859	894
			setupStore	8	5	14	2	8	9
Firefox	Browserify	Home	uiStartup	1338	1172	1971	144	1361	1694
			load	1199	1027	1798	138	1228	1545
			domContentLoaded	1198	1027	1798	138	1227	1545
			domInteractive	102	37	231	28	88	99
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	133	19	23	40
			firstReactRender	23	19	54	6	25	34
			getState	7	3	23	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1174	1012	1762	136	1198	1523
			setupStore	6	3	33	5	6	7
	Webpack	Home	uiStartup	974	842	1530	169	897	984
			load	854	741	1339	153	786	864
			domContentLoaded	854	740	1338	153	786	863
			domInteractive	113	41	191	22	136	94
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	84	10	23	32
			firstReactRender	19	16	35	3	19	23
			getState	9	4	73	10	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	837	727	1318	149	773	858
			setupStore	8	5	83	8	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-27T19:25:04Z

Builds ready [e59a841]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1259 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1259	1138	1466	57	1289	1359
			load	1104	1000	1227	52	1136	1200
			domContentLoaded	1099	996	1214	52	1141	1210
			domInteractive	19	14	79	14	16	76
			firstPaint	782	78	1219	436	206	304
			backgroundConnect	10	6	50	5	9	10
			firstReactRender	21	16	49	5	21	34
			getState	12	4	51	9	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	838	737	951	51	878	926
			setupStore	8	5	27	3	7	9
	Webpack	Home	uiStartup	922	828	1074	53	938	957
			load	796	693	915	53	825	881
			domContentLoaded	790	686	908	53	820	875
			domInteractive	15	11	43	7	13	33
			firstPaint	523	67	891	319	816	839
			backgroundConnect	14	10	24	4	15	24
			firstReactRender	13	12	15	1	13	14
			getState	6	3	11	1	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	788	685	898	52	816	865
			setupStore	7	4	11	1	8	9
Firefox	Browserify	Home	uiStartup	1458	1249	2130	183	1472	1968
			load	1304	1122	1966	178	1316	1805
			domContentLoaded	1304	1122	1965	178	1316	1805
			domInteractive	116	40	252	32	187	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	128	13	26	37
			firstReactRender	24	19	59	5	25	30
			getState	8	4	41	6	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1279	1099	1942	177	1293	1781
			setupStore	8	4	42	7	6	8
	Webpack	Home	uiStartup	1069	899	1681	169	945	982
			load	930	780	1483	155	853	937
			domContentLoaded	930	780	1483	155	852	937
			domInteractive	117	32	221	30	151	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	87	10	27	34
			firstReactRender	21	17	29	2	21	25
			getState	9	5	58	6	8	9
			initialActions	0	0	2	0	0	1
			loadScripts	909	765	1452	152	836	921
			setupStore	12	5	63	13	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-27T20:42:26Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/snaps-devs

ui/components/app/snaps/snap-ui-renderer/__snapshots__/snap-ui-renderer.test.js.snap
ui/components/app/snaps/snap-ui-renderer/components/__snapshots__/address-input.test.ts.snap
ui/components/app/snaps/snap-ui-renderer/components/__snapshots__/file-input.test.ts.snap
ui/components/app/snaps/snap-ui-renderer/components/__snapshots__/form.test.ts.snap
ui/components/app/snaps/snap-ui-renderer/components/address-input.test.ts
ui/components/app/snaps/snap-ui-renderer/components/file-input.test.ts
ui/components/app/snaps/snap-ui-renderer/components/form.test.ts
ui/components/app/snaps/snap-ui-renderer/snap-ui-renderer.test.js
ui/components/app/snaps/snap-ui-renderer/test-utils.tsx

metamaskbot · 2025-03-27T23:57:44Z

Builds ready [389e90b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1074	1331	59	1239	1288
			load	1039	946	1182	54	1182	989
			domContentLoaded	1034	935	1176	54	942	985
			domInteractive	16	13	33	4	15	26
			firstPaint	790	95	1164	387	245	966
			backgroundConnect	10	6	47	4	9	10
			firstReactRender	18	15	34	4	18	31
			getState	11	4	50	8	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	821	708	959	54	865	906
			setupStore	8	5	26	3	7	8
	Webpack	Home	uiStartup	916	813	1159	67	936	953
			load	778	578	983	69	819	878
			domContentLoaded	772	568	979	70	812	870
			domInteractive	15	12	36	6	13	31
			firstPaint	485	54	983	333	813	834
			backgroundConnect	16	11	53	9	15	41
			firstReactRender	14	12	26	3	13	24
			getState	7	4	27	3	6	8
			initialActions	0	0	1	0	0	0
			loadScripts	769	558	969	71	811	860
			setupStore	7	4	16	2	7	8
Firefox	Browserify	Home	uiStartup	1398	1228	2045	166	1424	1813
			load	1258	1107	1898	163	1295	1652
			domContentLoaded	1258	1107	1897	163	1295	1652
			domInteractive	112	37	200	31	82	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	18	50	4	24	30
			firstReactRender	23	19	54	4	24	29
			getState	7	4	40	4	7	8
			initialActions	0	0	1	0	1	1
			loadScripts	1237	1089	1873	161	1276	1622
			setupStore	7	4	34	4	6	9
	Webpack	Home	uiStartup	971	814	1439	159	887	980
			load	851	712	1313	143	799	965
			domContentLoaded	851	712	1313	143	798	965
			domInteractive	115	36	253	28	158	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	109	13	20	31
			firstReactRender	19	16	35	3	19	24
			getState	9	3	63	11	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	834	700	1291	139	784	958
			setupStore	7	4	52	5	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

ui/components/app/snaps/snap-ui-renderer/test-utils.tsx

ui/components/app/snaps/snap-ui-renderer/snap-ui-renderer.test.js

ui/components/app/snaps/snap-ui-renderer/components/file-input.test.ts

ui/components/app/snaps/snap-ui-renderer/components/address-input.test.ts

ui/components/app/snaps/snap-ui-renderer/test-utils.tsx

metamaskbot · 2025-03-28T12:23:35Z

Builds ready [8bc0f60]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1179 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1179	1062	1473	64	1218	1283
			load	1029	906	1242	61	936	990
			domContentLoaded	1023	899	1232	61	929	986
			domInteractive	15	12	38	4	15	25
			firstPaint	704	136	1241	412	232	988
			backgroundConnect	10	6	53	7	9	9
			firstReactRender	19	14	42	5	19	33
			getState	11	4	36	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	814	694	1019	59	860	904
			setupStore	7	4	21	2	7	9
	Webpack	Home	uiStartup	943	809	1233	72	954	973
			load	801	600	965	65	834	892
			domContentLoaded	796	581	954	66	829	882
			domInteractive	15	12	42	6	13	33
			firstPaint	480	66	957	335	826	847
			backgroundConnect	16	11	53	9	14	40
			firstReactRender	14	12	32	3	13	23
			getState	6	4	14	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	794	571	943	66	827	871
			setupStore	7	5	14	2	7	8
Firefox	Browserify	Home	uiStartup	1381	1195	2001	153	1414	1744
			load	1238	1074	1817	141	1283	1571
			domContentLoaded	1237	1074	1817	141	1283	1571
			domInteractive	99	36	178	25	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	16	200	21	26	40
			firstReactRender	23	19	51	4	24	29
			getState	8	4	46	6	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1212	1058	1794	139	1261	1543
			setupStore	6	4	34	4	6	7
	Webpack	Home	uiStartup	992	824	1515	150	929	987
			load	866	718	1328	129	828	950
			domContentLoaded	865	718	1327	129	828	950
			domInteractive	118	39	224	24	146	99
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	78	9	23	38
			firstReactRender	19	16	32	3	20	25
			getState	8	4	62	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	848	705	1304	126	828	947
			setupStore	10	5	78	13	7	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

ui/components/app/snaps/snap-ui-renderer/components/input.test.ts

metamaskbot · 2025-03-28T15:42:32Z

Builds ready [1f3aa90]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1183 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1183	1068	1311	57	1222	1302
			load	1029	943	1164	52	951	978
			domContentLoaded	1023	939	1159	52	947	977
			domInteractive	16	13	32	4	15	28
			firstPaint	761	82	1150	387	264	975
			backgroundConnect	10	7	51	5	8	9
			firstReactRender	19	15	48	5	19	31
			getState	10	4	29	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	811	725	935	52	841	901
			setupStore	8	5	31	3	7	8
	Webpack	Home	uiStartup	948	820	1273	80	952	970
			load	808	688	971	58	838	890
			domContentLoaded	802	673	960	57	831	877
			domInteractive	15	12	40	7	14	35
			firstPaint	459	54	951	342	825	878
			backgroundConnect	16	11	46	8	15	39
			firstReactRender	14	12	34	4	13	25
			getState	6	4	12	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	800	663	949	57	830	875
			setupStore	7	4	15	2	7	9
Firefox	Browserify	Home	uiStartup	1373	1150	1837	145	1410	1742
			load	1235	1035	1704	139	1292	1583
			domContentLoaded	1235	1035	1704	139	1291	1583
			domInteractive	98	40	176	27	91	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	71	9	28	43
			firstReactRender	22	19	50	4	23	27
			getState	7	4	35	4	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1210	1015	1684	136	1267	1542
			setupStore	6	4	26	3	6	8
	Webpack	Home	uiStartup	982	833	1600	176	897	971
			load	862	729	1371	156	804	903
			domContentLoaded	862	728	1371	156	803	903
			domInteractive	110	40	184	21	137	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	108	14	21	33
			firstReactRender	18	16	27	2	19	23
			getState	9	3	101	12	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	846	714	1342	153	793	930
			setupStore	8	4	62	8	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-28T20:33:16Z

Builds ready [9d5eb06]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1170 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1170	1062	1402	58	1199	1271
			load	1023	927	1217	55	951	993
			domContentLoaded	1017	923	1207	55	951	996
			domInteractive	16	12	33	4	15	26
			firstPaint	712	130	1219	401	248	981
			backgroundConnect	9	6	21	2	9	10
			firstReactRender	19	14	44	5	19	34
			getState	11	4	39	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	805	694	982	55	831	904
			setupStore	8	5	28	3	7	8
	Webpack	Home	uiStartup	955	752	1270	79	966	993
			load	807	623	987	70	848	909
			domContentLoaded	802	609	983	71	841	898
			domInteractive	16	12	48	8	14	36
			firstPaint	416	55	978	339	832	864
			backgroundConnect	16	12	56	9	15	42
			firstReactRender	14	12	32	3	14	24
			getState	7	3	13	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	799	598	981	71	838	887
			setupStore	8	5	18	2	8	9
Firefox	Browserify	Home	uiStartup	1387	1202	2021	155	1413	1748
			load	1250	1068	1872	150	1286	1585
			domContentLoaded	1250	1067	1872	150	1286	1584
			domInteractive	110	40	268	33	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	136	16	25	41
			firstReactRender	22	19	33	3	24	27
			getState	6	4	37	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1225	1024	1847	149	1269	1560
			setupStore	6	4	23	3	6	6
	Webpack	Home	uiStartup	992	859	1474	140	921	984
			load	867	740	1320	126	829	978
			domContentLoaded	867	739	1320	126	829	976
			domInteractive	114	35	165	29	150	94
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	85	13	24	36
			firstReactRender	19	16	29	2	19	25
			getState	8	4	53	7	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	850	724	1287	123	815	958
			setupStore	8	5	39	5	8	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-31T13:55:28Z

Builds ready [5166d35]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1213 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1213	1101	1358	59	1253	1325
			load	1053	968	1201	54	1134	992
			domContentLoaded	1047	964	1177	53	1172	994
			domInteractive	17	13	34	5	16	32
			firstPaint	841	149	1189	368	239	980
			backgroundConnect	10	7	31	4	9	10
			firstReactRender	19	15	49	4	19	29
			getState	12	4	36	8	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	829	742	962	52	855	942
			setupStore	8	5	18	2	7	8
	Webpack	Home	uiStartup	921	719	1179	71	945	969
			load	778	588	908	66	826	858
			domContentLoaded	773	585	900	67	822	850
			domInteractive	15	12	40	7	13	37
			firstPaint	393	53	903	327	811	895
			backgroundConnect	16	11	55	9	14	37
			firstReactRender	14	12	28	3	13	24
			getState	6	3	21	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	770	582	890	67	821	841
			setupStore	7	5	14	2	7	9
Firefox	Browserify	Home	uiStartup	1389	1177	2054	160	1396	1846
			load	1249	1062	1890	153	1261	1656
			domContentLoaded	1249	1062	1890	153	1261	1656
			domInteractive	98	40	203	26	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	143	14	25	34
			firstReactRender	23	19	52	5	24	31
			getState	6	4	31	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1226	1046	1870	150	1242	1630
			setupStore	6	4	12	2	6	7
	Webpack	Home	uiStartup	986	822	1743	186	894	973
			load	862	715	1558	164	823	939
			domContentLoaded	861	715	1557	164	822	939
			domInteractive	114	41	200	24	165	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	148	16	21	31
			firstReactRender	19	16	37	3	19	26
			getState	10	3	105	13	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	844	700	1420	156	818	951
			setupStore	9	5	96	11	7	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-31T14:50:32Z

Builds ready [7aa3c9e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1201 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1201	1089	1490	67	1233	1350
			load	1047	942	1321	66	1172	983
			domContentLoaded	1040	938	1315	66	941	994
			domInteractive	17	13	59	6	16	29
			firstPaint	789	129	1320	393	247	984
			backgroundConnect	13	7	149	19	9	10
			firstReactRender	20	12	45	6	21	36
			getState	12	4	34	7	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	822	719	1088	65	843	899
			setupStore	8	5	15	2	7	9
	Webpack	Home	uiStartup	959	768	1330	79	960	983
			load	817	611	924	59	844	903
			domContentLoaded	811	594	914	59	837	892
			domInteractive	16	12	45	7	14	36
			firstPaint	504	55	917	347	835	912
			backgroundConnect	16	11	52	9	15	40
			firstReactRender	14	12	31	4	13	24
			getState	7	4	15	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	809	583	904	59	835	882
			setupStore	7	5	14	2	8	9
Firefox	Browserify	Home	uiStartup	1474	1232	2007	154	1545	1795
			load	1326	1109	1807	152	1411	1634
			domContentLoaded	1325	1108	1807	152	1411	1634
			domInteractive	121	41	259	36	41	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	18	262	24	26	34
			firstReactRender	24	20	41	3	25	29
			getState	7	4	26	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1300	1091	1769	146	1391	1605
			setupStore	6	4	13	2	6	8
	Webpack	Home	uiStartup	969	811	1564	160	892	980
			load	849	709	1387	142	826	935
			domContentLoaded	849	709	1387	142	826	935
			domInteractive	114	39	187	20	148	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	85	10	21	30
			firstReactRender	18	16	25	2	18	23
			getState	9	4	89	11	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	833	697	1368	139	807	926
			setupStore	9	5	84	11	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

move component tests into their own files

0409d5b

hmalik88 added the team-snaps-platform Snaps Platform team label Mar 27, 2025

Merge branch 'main' into hm/refactor-snap-component-tests

bbc840e

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 27, 2025

hmalik88 marked this pull request as ready for review March 27, 2025 16:56

hmalik88 requested a review from a team as a code owner March 27, 2025 16:56

hmalik88 added 3 commits March 27, 2025 13:48

change to ts

6b8d19b

Merge branch 'main' into hm/refactor-snap-component-tests

0f568e5

rm unnecessary files

63f8c77

hmalik88 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 27, 2025

hmalik88 added 2 commits March 27, 2025 14:32

lint fix

74ff4ea

Merge branch 'main' into hm/refactor-snap-component-tests

e59a841

lint fix

6fe0c54

hmalik88 added 2 commits March 27, 2025 19:17

Merge branch 'main' into hm/refactor-snap-component-tests

51c78f3

fix lint error

389e90b

Mrtenz reviewed Mar 28, 2025

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/test-utils.tsx Show resolved Hide resolved

FrederikBolding reviewed Mar 28, 2025

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/snap-ui-renderer.test.js Show resolved Hide resolved

FrederikBolding reviewed Mar 28, 2025

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/components/file-input.test.ts Outdated Show resolved Hide resolved

FrederikBolding reviewed Mar 28, 2025

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/components/address-input.test.ts Outdated Show resolved Hide resolved

FrederikBolding reviewed Mar 28, 2025

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/test-utils.tsx Outdated Show resolved Hide resolved

hmalik88 added 4 commits March 28, 2025 06:31

add return type and jsdoc

f7ae97b

update test names, move tests

c8a519a

Merge branch 'main' into hm/refactor-snap-component-tests

babb8d6

update snapshots

8bc0f60

FrederikBolding reviewed Mar 28, 2025

View reviewed changes

ui/components/app/snaps/snap-ui-renderer/components/input.test.ts Outdated Show resolved Hide resolved

hmalik88 added 3 commits March 28, 2025 11:02

move input and footer tests back to snap-ui-renderer

ad705bf

Merge branch 'main' into hm/refactor-snap-component-tests

2c0c72c

update snapshot

1f3aa90

hmalik88 requested review from FrederikBolding and Mrtenz March 28, 2025 15:06

Merge branch 'main' into hm/refactor-snap-component-tests

9d5eb06

FrederikBolding previously approved these changes Mar 31, 2025

View reviewed changes

hmalik88 added 2 commits March 31, 2025 05:25

Merge branch 'main' into hm/refactor-snap-component-tests

f0096ce

update snapshots

3ba4bcf

hmalik88 dismissed FrederikBolding’s stale review via 3ba4bcf March 31, 2025 09:28

FrederikBolding approved these changes Mar 31, 2025

View reviewed changes

Merge branch 'main' into hm/refactor-snap-component-tests

5166d35

Merge branch 'main' into hm/refactor-snap-component-tests

7aa3c9e

GuillaumeRx approved these changes Mar 31, 2025

View reviewed changes

hmalik88 enabled auto-merge March 31, 2025 14:23

hmalik88 added this pull request to the merge queue Mar 31, 2025

Merged via the queue into main with commit 56a90ac Mar 31, 2025
147 checks passed

hmalik88 deleted the hm/refactor-snap-component-tests branch March 31, 2025 15:54

github-actions bot locked and limited conversation to collaborators Mar 31, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move Snap component tests into their own files #31361

chore: move Snap component tests into their own files #31361

hmalik88 commented Mar 27, 2025 •

edited

Loading

github-actions bot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025 •

edited

Loading

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 28, 2025

metamaskbot commented Mar 28, 2025

metamaskbot commented Mar 28, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

chore: move Snap component tests into their own files #31361

chore: move Snap component tests into their own files #31361

Conversation

hmalik88 commented Mar 27, 2025 • edited Loading

Description

Related issues

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 27, 2025 • edited Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Mar 27, 2025

metamaskbot commented Mar 28, 2025

metamaskbot commented Mar 28, 2025

metamaskbot commented Mar 28, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

hmalik88 commented Mar 27, 2025 •

edited

Loading

metamaskbot commented Mar 27, 2025 •

edited

Loading