Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: View address of an added token #4440

Closed
haydenadams opened this issue Jun 1, 2018 · 18 comments
Closed

Feature: View address of an added token #4440

haydenadams opened this issue Jun 1, 2018 · 18 comments
Labels
area-UI Relating to the user interface. needs-design Needs design support.

Comments

@haydenadams
Copy link

Unless I'm missing something, its impossible to view the address of an already added token unless you have made a previous transaction to that token. There should absolutely be some way of viewing/copying or opening the address in etherscan. This was a feature before the redesign.

@bdresser bdresser added area-UI Relating to the user interface. needs-design Needs design support. labels Jun 1, 2018
@bdresser
Copy link
Contributor

bdresser commented Jun 7, 2018

@danjm @cjeria @danfinlay what do you guys think? maybe right on the on the 20 BCK or by clicking an icon next to it?
screen shot 2018-06-07 at 10 01 46 am

or, we could add in the ... psuedo-menu below "Hide Token"
screen shot 2018-06-07 at 10 02 12 am

@danfinlay
Copy link
Contributor

I think that's a good looking proposal, we could easily add "Copy token address" to the menu there. Is probably simple enough to post a bounty for a community solution.

@bdresser
Copy link
Contributor

bdresser commented Jun 7, 2018

@danfinlay "Copy address" or just "View on Etherscan" ? Old UI does the latter which I kinda like

@danfinlay
Copy link
Contributor

If it's just menu options, we could easily add both. I agree viewing on etherscan is nice.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.2 ETH (100.36 USD @ $501.79/ETH) attached to it.

@bdresser
Copy link
Contributor

bounty should add two options below the "Hide Token" option on our Beta UI

(1) "Copy Contract Address"
(2) "View on Etherscan"

@alextsg or @danjm can help with specific questions

@gitcoinbot
Copy link

gitcoinbot commented Jun 15, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months, 1 week from now.
Please review their action plans below:

1) scsaba has started work.

Adding the requested items.

Learn more on the Gitcoin Issue Details page.

@cjeria
Copy link
Contributor

cjeria commented Jun 15, 2018

Sounds like a good quick-n-dirty solution for adding new controls. Since this is a common functionality of all tokens, we should probably create a new design issue for a potentially better placement of these controls. I while ago we talked about possibly repositioning token-specific action controls somewhere within the token balance view.

@bdresser
Copy link
Contributor

@cjeria that makes total sense. let's use this to get the new UI to parity with the old for rollout, and that sounds like an awesome evolution once new UI is out to 100%. sound good?

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.2 ETH (99.61 USD @ $498.04/ETH) has been submitted by:

  1. @scsaba

@bdresser please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.2 ETH (99.53 USD @ $497.65/ETH) attached to this issue has been approved & issued to @scsaba.

@bdresser
Copy link
Contributor

thanks @scsaba ! nice work

@scsaba
Copy link
Contributor

scsaba commented Jun 18, 2018

Thank you guys!

@rdymac
Copy link

rdymac commented Aug 16, 2018

We need to look for way to make it more difficult for users to get confused about the "Copy Contract Address" (case: 5575) because some people are using it as receiving address for tokens withdrawals from exchanges and other wallets.

A Token Details button showing a window with the Token’s details like:

  • Name
  • Contract address (with a WARNING saying DON’T USE THIS ADDRESS TO RECEIVE TOKENS)
  • Decimals

This would let us show a more useful window that we can use to educate users about not using a contract address for what it is not meant to be.

@bdresser
Copy link
Contributor

@rdymac see #3185

this is also a perfect example of straddling new users & developer/experienced users.

@haydenadams for context - we've had a couple reports of folks misinterpreting this address as their own address and trying to use it to receive tokens.

How would you feel if we hid this link by default and added a toggle in settings to enable it?

@rdymac
Copy link

rdymac commented Aug 17, 2018

@bdresser, in response to that comment you've made to @haydenadams and also what was mentioned elsewhere: if a token's Contract Address has already been added manually and we have a 'View On Etherscan' button, why is a 'Copy Contract Address' button needed right there if it is meant to be used only by advanced users which can obtain that info easily from Etherscan?

I think the 'Token Details' button with a view/popup (ala the Deposit/Receive one) would work better, so it can show more info and we can add a warning message to it. Maybe it will also be useful for ERC721 tokens to provide useful info too.

Here is another example of a user confused in the new UI when trying to receive/deposit tokens to the just added Token: case 5742

Add a 'Deposit' button to the token specific section which would fire the Account's address popup makes a lot of sense there

captura de pantalla 2018-08-17 a las 17 43 07

captura de pantalla 2018-08-17 a las 17 45 13

Add the Deposit button to the Token window, and show an address popup like the one above.

captura de pantalla 2018-08-17 a las 17 44 36

@haydenadams
Copy link
Author

@bdresser I'm somewhat ambivalent on "copy contract address" vs "view on Etherscan" but imo at least one of them should exposed without having to go into settings to toggle something.

@bdresser
Copy link
Contributor

@rdymac sounds good, let's remove. Opened #5103

I think we were trying to be too helpful 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. needs-design Needs design support.
Projects
None yet
Development

No branches or pull requests

7 participants