Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View address of an added token #4591

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Conversation

scsaba
Copy link
Contributor

@scsaba scsaba commented Jun 16, 2018

Fixes #4440

Added the "Copy Contract Address" and "View on Etherscan" actions.
There were two similar items in messages.json, "Copy to clipboard" and "View account on Etherscan", but in my opinion they do not describe these actions properly, hence I added these also.

image

@bdresser
Copy link
Contributor

bdresser commented Jun 16, 2018

hey @scsaba, thanks for the fast turnaround and good work!

apologies for not including a visual mock - we'd like this to match the other dark menus throughout the extension. could you add a little more padding between each menu option? check out the "My Accounts" dropdown in the top right of the extension, and the menu__item and menu__item--clickable classes. let me know if you have questions 👍

@scsaba
Copy link
Contributor Author

scsaba commented Jun 16, 2018

@bdresser thanks for the quick feedback, will adjust the style :)

@scsaba
Copy link
Contributor Author

scsaba commented Jun 16, 2018

@bdresser, do you mean this dropdown on the old UI?

image

@bdresser
Copy link
Contributor

bdresser commented Jun 16, 2018 via email

@scsaba
Copy link
Contributor Author

scsaba commented Jun 16, 2018

@bdresser after changing the style:

image

@bdresser
Copy link
Contributor

looks great @scsaba! @danjm or @alextsg will review early next week.

FYI @cjeria

@scsaba
Copy link
Contributor Author

scsaba commented Jun 18, 2018

Hi @bdresser, @danjm, @alextsg, I think that build failure is not related to my change. Could you please trigger a new build or should I push something that does the job?

@alextsg alextsg merged commit 8aab4dd into MetaMask:develop Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants