Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI RPC URL Discrepancy #6321

Closed
CruzMolina opened this issue Mar 19, 2019 · 6 comments · Fixed by #6444
Closed

UI RPC URL Discrepancy #6321

CruzMolina opened this issue Mar 19, 2019 · 6 comments · Fixed by #6444

Comments

@CruzMolina
Copy link

CruzMolina commented Mar 19, 2019

Hey MM team!

Noticed a discrepancy on the UI.

Screen Shot 2019-03-19 at 9 37 37 AM

Are the current intentions to support the RPC URL as localhost 8545 or localhost 9545?

Thanks for your time! 🍫

MM: 6.2.2
Browser: Chrome Version 72.0.3626.121 (Official Build) (64-bit)
OS: macOS 10.13.6 (High Sierra)

@tmashuang
Copy link
Contributor

What's running on that port, Ganache, parity, geth, or etc.?

@adrianmcli
Copy link

Wouldn't it be nice if we could standardize on a port number for all local dev?

@CruzMolina
Copy link
Author

@tmashuang ganache is running on 8545 in that screenshot.

I'm unable to have MM connect w/ ganache on 9545 unless I specify correct Custom RPC settings. The discrepancy is more that the text at the top shows http://127.0.0.1:9545 while ganache is running on 8545.

@tmashuang
Copy link
Contributor

tmashuang commented Mar 19, 2019

We're overriding default localhost data. So if there was a previous connection to http://127.0.01:9545 / http://127.0.01:7545 it will change the localhost 8545 nickname we show at the selected network. Fix will be in the next version.

@joshmobley
Copy link

Also, a long rpc endpoint url (with auth) breaks the UI.

It overflows the container preventing access to the account switcher.

@bdresser
Copy link
Contributor

bdresser commented Apr 8, 2019

@joshmobley tracked in #6094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants