Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web3_clientVersion RPC call returns an error #8993

Closed
Moejoe90 opened this issue Jul 15, 2020 · 3 comments · Fixed by #8998
Closed

web3_clientVersion RPC call returns an error #8993

Moejoe90 opened this issue Jul 15, 2020 · 3 comments · Fixed by #8998
Assignees
@Gudahtt
Labels
type-bug Something isn't working

Comments

@Moejoe90
Copy link

Moejoe90 commented Jul 15, 2020 •
edited
Loading

Describe the bug
It seems that you have disabled web3_clientVersion, since we can't use this RPC call in our dapp anymore to know if the client is metamask or not.

RPC Error: The method 'web3_clientVersion' does not exist / is not available

Maybe this is on purpose and there is a different way to do this now, in all cases please advice

To Reproduce (REQUIRED)

  1. Go to platform.neufund.org
  2. Click on login
  3. Click on Metamask
  4. Try to Login
  5. Error show's in the console

Expected behavior
The metamask client should return the client version without any issues unless this is known behaviour

Additional context (Error Messages, etc.)
code: -32601, message: "The method 'web3_clientVersion' does not exist / is not available."
@Gudahtt Gudahtt added the type-bug Something isn't working label Jul 15, 2020
@Gudahtt
Copy link
Member

Gudahtt commented Jul 15, 2020

Thanks for the report! I was able to reproduce this.

@DeltaBalances
Copy link

I noticed this in several decentralized exchanges using parts of the etherdelta codebase.
web3.version.getNode() using web3.js version 0.2.x returns the same error.

Wasn't sure if this was a bug or simply a deprecation in the new API

@Gudahtt
Copy link
Member

Gudahtt commented Jul 15, 2020

This was unintentional; we try to provide adequate advanced notice for any intentional breakages.

This will be fixed in the next update.

@Gudahtt Gudahtt self-assigned this Jul 15, 2020
Gudahtt added a commit that referenced this issue Jul 15, 2020
@Gudahtt
Fix web3_clientVersion method
1d56b04 
This method was accidentally broken with the introduction of the
permissions controller, as this was missing from the list of safe
methods.

It is now included in the list of safe methods.

Fixes #8993
@Gudahtt Gudahtt mentioned this issue Jul 15, 2020
Merged
Gudahtt added a commit that referenced this issue Jul 15, 2020
@Gudahtt
Fix web3_clientVersion method (#8998)
0130108 
This method was accidentally broken with the introduction of the
permissions controller, as this was missing from the list of safe
methods.

It is now included in the list of safe methods.

Fixes #8993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gudahtt Gudahtt

Labels
type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix web3_clientVersion method MetaMask/metamask-extension
3 participants
@Gudahtt @Moejoe90 @DeltaBalances