Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct block explorer name and link in swaps when on custom network #10743

Merged
merged 8 commits into from
Mar 29, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Mar 26, 2021

Fixes an issue found by @tmashuang when QAing v9.3.0

Before:

After:

@danjm danjm requested a review from a team as a code owner March 26, 2021 22:39
@danjm danjm requested a review from NiranjanaBinoy March 26, 2021 22:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [42fa526]
Page Load Metrics (527 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42614963
domContentLoaded3395765267436
load3405765277436
domInteractive3395755257436

@metamaskbot
Copy link
Collaborator

Builds ready [7a5b0dd]
Page Load Metrics (678 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4910667136
domContentLoaded41482467710550
load41582567810550
domInteractive41482467710550

@danjm danjm force-pushed the swaps-custom-network-chain-explorer branch from 82eb536 to 60f1d34 Compare March 28, 2021 12:06
@metamaskbot
Copy link
Collaborator

Builds ready [60f1d34]
Page Load Metrics (561 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45695884
domContentLoaded3656735599244
load3666745619244
domInteractive3646735599244

@danjm danjm changed the base branch from develop to update-etherscan-link-version March 28, 2021 12:32
Base automatically changed from update-etherscan-link-version to develop March 28, 2021 15:02
@danjm danjm force-pushed the swaps-custom-network-chain-explorer branch from 6e8b0c9 to a731fc9 Compare March 28, 2021 23:12
@metamaskbot
Copy link
Collaborator

Builds ready [a731fc9]
Page Load Metrics (504 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42645063
domContentLoaded3275915039747
load3285925049747
domInteractive3265915039747

@metamaskbot
Copy link
Collaborator

Builds ready [bcd4b0a]
Page Load Metrics (594 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4510163126
domContentLoaded36778659310349
load36878759410349
domInteractive36778659210349

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm merged commit d8fd4b8 into develop Mar 29, 2021
@danjm danjm deleted the swaps-custom-network-chain-explorer branch March 29, 2021 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants