Build - refactor background process to use html #10769
Conversation
Builds ready [b3cda44]
Page Load Metrics (506 ± 53 ms)
|
| @@ -80,13 +80,34 @@ const copyTargetsDev = [ | |||
| pattern: '/chromereload.js', | |||
| dest: ``, | |||
| }, | |||
| // empty files to suppress missing file errors | |||
There was a problem hiding this comment.
Huh, that's an interesting idea!
I had been meaning to address this warning by updating the build script to use these dependency bundles in development too, rather than just in prod. But I never got around to it. This seems like a simpler solution for now.
There was a problem hiding this comment.
yeah this solution is sort of dumb and silly but saves a good chunk of code dedicated to conditionally flipping on and off script imports. simplicity won me over here.
There was a problem hiding this comment.
++ (discussed on Discord, but for now the empty.js file workaround is preferable to the alternative, which can be accomplished in a separate task)
@Gudahtt left some nits, but ran through smoke tests on both dev and prod builds and all looked good to me!
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Builds ready [6e49fcc]
Page Load Metrics (575 ± 43 ms)
|
aligns background process entry point to match format of the other entry points (ui/home, ui/popup, ...). this will enable the "flat file" build refactor
additonally, instead of logic for adding/removing scripts from the build, i opted for copying empty files to replace the expected files