Set the BSC_CONTRACT_ADDRESS to lowercase

[danjm]

Set the BSC_CONTRACT_ADDRESS to lowercase. This makes it consistent with other address constants and the way all addresses are handled in our front-end. This fixes a bug found while I was QAing where swaps transactions don't appear in token specific views while on binance.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Gudahtt]

swaps transactions don't appear in token specific views while on binance.

How did the case of the address cause this to happen? 🤔

[tmashuang]

Is this the case where txParams.to is not checksummed?

metamask-extension/ui/app/components/app/transaction-list/transaction-list.component.js

Line 32 in 480512d

(txParams?.to === SWAPS_CHAINID_CONTRACT_ADDRESS_MAP[chainId] &&

[danjm]

How did the case of the address cause this to happen? 🤔

@Gudahtt See Thomas' comment above

[danjm]

But maybe then there is a question of why the to params are not checksummed... perhaps because we get it from the api?

[danjm]

oh, we normalize it to lowercase in addUnapprovedTransaction

[metamaskbot]

Builds ready [e39a604]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts

Page Load Metrics (531 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	46	71	55	7	4
		domContentLoaded	385	723	530	102	49
		load	387	724	531	102	49
		domInteractive	385	723	529	102	49

[tmashuang]

LGTM