EIP-1559 - Provide support for Ledger #11786
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Just tested this briefly on the latest Ledger Live software update. I see |
|
FWIW signing 1559 transactions works fine with ledger when used with mycrypto.com's ledger support. The ledger confirmation screen shows the max fee as nonzero, and the transaction goes through as expected. I tried this patch and got the same results as you - Ledger shows 0 max gas, and the txn fails in metamask immediately. |
|
I've updated the testing steps; to pin to the exact version of Ledger we need for Palm and EIP-1559 support, since updating to a newer version is a breaking change. |
| return !isHardwareWallet(state); | ||
| // Only Ledger supports 1559 at this times | ||
| const currentKeyring = getCurrentKeyring(state); | ||
| return currentKeyring && currentKeyring.type !== 'Trezor Hardware'; |
There was a problem hiding this comment.
Nit: this literal 'Trezor Hardware' is used in a few places throughout the codebase (defined as KEYRING_TYPES.TREZOR in MetamaskController) this would be a good candidate for a shared constant I think
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
|
This PR was superceded by #11951 |
Fixes: Provides Ledger support for EIP-1559
Depends on:
How to Test
node_modules/@metamask/eth-ledger-bridge-keyring/index.jsfile, changeBRIDGE_URLto'https://darkwing.github.io/eth-ledger-bridge-keyring', comment out the lines changed in this PR (Allow 1559 transactions with Ledger eth-ledger-bridge-keyring#93), and comment out theorigincheck in the_sendMessagemethod.