Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Chrome version to 66 #11995

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Sep 1, 2021

This PR updates our minimum supported Chrome version from 63 to 66, so that we may use the AbortController browser API without polyfilling it.

Our minimum Firefox version supports the AbortController, but our current minimum Chrome version (63, released in December 2017) does not. Chrome shipped the AbortController in version 66, in April 2018. We have determined that an extremely small number of users are on Chrome 63 < 66, and that this change is therefore acceptable.

@rekmarks rekmarks requested a review from a team as a code owner September 1, 2021 19:57
@rekmarks rekmarks requested a review from brad-decker September 1, 2021 19:57
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum browser versions are also in the manifest - it should be updated there as well.

@rekmarks rekmarks requested a review from Gudahtt September 1, 2021 20:00
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks mentioned this pull request Sep 1, 2021
5 tasks
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [200865d]
Page Load Metrics (462 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3786554588742
domContentLoaded3626454409144
load3806924629244
domInteractive3626454409144

@rekmarks rekmarks merged commit 8d9989c into develop Sep 1, 2021
@rekmarks rekmarks deleted the bump-minimum-browser-version branch September 1, 2021 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants