Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector performance improvements #17410

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 25, 2023

Explanation

  • Stopped calculating checksummed addresses in all selectors since the addresses are compared without case sensitivity.

@metamaskbot
Copy link
Collaborator

Builds ready [53118ab]
Page Load Metrics (1301 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951761252110
domContentLoaded100418171277228110
load104218171301225108
domInteractive100418171277228110
Bundle size diffs
  • background: 0 bytes
  • ui: -312 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

Codecov Report

Merging #17410 (53118ab) into develop (3e3abca) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           develop   #17410   +/-   ##
========================================
  Coverage    59.82%   59.82%           
========================================
  Files          938      938           
  Lines        35794    35794           
  Branches      9224     9224           
========================================
  Hits         21412    21412           
  Misses       14382    14382           
Impacted Files Coverage Δ
ui/selectors/selectors.js 65.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FrederikBolding FrederikBolding changed the title More Signature performance improvements Selector performance improvements Jan 26, 2023
@FrederikBolding FrederikBolding marked this pull request as ready for review January 26, 2023 13:00
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 26, 2023 13:00
montelaidev
montelaidev previously approved these changes Jan 27, 2023
Copy link
Contributor

@montelaidev montelaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [83a0b36]
Page Load Metrics (1679 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1032671393718
domContentLoaded14081889167213665
load14081978167914469
domInteractive14081889167213665
Bundle size diffs
  • background: 0 bytes
  • ui: -316 bytes
  • common: 0 bytes

@FrederikBolding FrederikBolding merged commit 63cbcc7 into develop Feb 27, 2023
@FrederikBolding FrederikBolding deleted the fb/more-signature-performance-improvements branch February 27, 2023 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants