-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX - Update all copy icons #17445
Merged
Merged
UX - Update all copy icons #17445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
force-pushed
the
update-copy-icons
branch
from
January 27, 2023 14:33
23f7cf3
to
fcf069c
Compare
darkwing
force-pushed
the
update-copy-icons
branch
from
January 30, 2023 19:09
99736ea
to
08dffa5
Compare
Builds ready [08dffa5]
Page Load Metrics (1307 ± 105 ms)
Bundle size diffs
|
pedronfigueiredo
previously approved these changes
Jan 31, 2023
darkwing
force-pushed
the
update-copy-icons
branch
from
January 31, 2023 15:04
08dffa5
to
86e7941
Compare
Builds ready [86e7941]
Page Load Metrics (1499 ± 140 ms)
Bundle size diffs
|
brad-decker
approved these changes
Jan 31, 2023
pedronfigueiredo
approved these changes
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
useCopyToClipboard
hook everywhereui/components/app/collectible-details/collectible-details.js
doesExplanation
The extension uses a new icon for the copy button. We should update all instances where copying is done.
Screenshots/Screencaps
Coming soon...
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.