Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX - Update all copy icons #17445

Merged
merged 14 commits into from
Jan 31, 2023
Merged

UX - Update all copy icons #17445

merged 14 commits into from
Jan 31, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jan 26, 2023

TODO

  • Use useCopyToClipboard hook everywhere
  • Update the icon upon click like ui/components/app/collectible-details/collectible-details.js does
  • Create screenshots

Explanation

The extension uses a new icon for the copy button. We should update all instances where copying is done.

Screenshots/Screencaps

Coming soon...

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner January 26, 2023 22:45
@darkwing darkwing marked this pull request as draft January 26, 2023 22:45
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing marked this pull request as ready for review January 27, 2023 23:18
@metamaskbot
Copy link
Collaborator

Builds ready [08dffa5]
Page Load Metrics (1307 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint983541325426
domContentLoaded102516991293219105
load102516991307218105
domInteractive102516991293219105
Bundle size diffs
  • background: 0 bytes
  • ui: -691 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [86e7941]
Page Load Metrics (1499 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1102601414220
domContentLoaded103420381454281135
load103420381499291140
domInteractive103420381454281135
Bundle size diffs
  • background: 0 bytes
  • ui: -691 bytes
  • common: 0 bytes

@darkwing darkwing merged commit 145cf1e into develop Jan 31, 2023
@darkwing darkwing deleted the update-copy-icons branch January 31, 2023 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants