feat: Make the valid Token Symbol Length Parametric #17642

miladtsx · 2023-02-07T15:54:48Z

This pull request is to resolve issue #9243.

github-actions · 2023-02-07T15:55:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

miladtsx · 2023-02-07T15:59:34Z

I have read the CLA Document and I hereby sign the CLA

matrixise · 2023-04-04T07:44:08Z

ping

legobeat · 2023-04-27T04:53:44Z

ui/pages/import-token/import-token.component.js

@@ -367,8 +367,8 @@ class ImportToken extends Component {
    const symbolLength = customSymbol.length;
    let customSymbolError = null;

-    if (symbolLength <= 0 || symbolLength >= 12) {
-      customSymbolError = this.context.t('symbolBetweenZeroTwelve');
+    if (symbolLength === 0 || symbolLength >= 100) {


If this could be replaced with a configuration variable, this could be changed in teh future without requiring any changes to localization files.

See how other messages utilize templating by $1,$2, etc to create dynamic templates, where the max-length could be a new template value here.

@legobeat good idea! it is parametric now.

github-actions · 2023-07-20T11:49:40Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions · 2023-09-23T18:04:39Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions · 2023-11-24T00:15:15Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

fredwes · 2024-05-27T18:27:48Z

Sorry to keep bumping here but our users have reported issues adding tokens due to this. @legobeat any update on getting this merged in?

legobeat · 2024-05-27T22:09:53Z

Sorry to keep bumping here but our users have reported issues adding tokens due to this. @legobeat any update on getting this merged in?

@fredwes Unfortunately, I don't have any further insights on the progress to share at this time.

@MetaMask/extension-devs Could we get some eyes on this, please? Any UI/UX concerns?

bergeron · 2024-06-03T14:39:47Z

This is a good idea, and MetaMask should support longer symbol lengths. There are other parts of the codebase that would need to be updated. At least here but maybe others. And it would require some UI work to consider every place showing symbols to make sure they render correctly, and do something like an ... ellipses or truncation to make it fit. So I don't think this can be merged as is.

github-actions · 2024-08-02T16:04:57Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

greptile-apps

PR Summary

The pull request updates localization files to support a parametric token symbol length, increasing the limit to 20 characters.

Updated validation message for token symbol length in app/_locales/et/messages.json to be parametric.
Similar updates made across multiple localization files, including app/_locales/cs/messages.json, app/_locales/am/messages.json, and others.
Removed old fixed-length messages and replaced them with dynamic messages using placeholders.
Ensured consistency in validation logic across all affected localization files.
No security issues or logical errors identified; changes are straightforward localization updates.

_{30 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

codecov · 2024-08-11T22:06:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (91dc6ea) to head (8d813c1).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #17642   +/-   ##
========================================
  Coverage    70.10%   70.10%           
========================================
  Files         1430     1430           
  Lines        50147    50148    +1     
  Branches     13872    13872           
========================================
+ Hits         35152    35153    +1     
  Misses       14995    14995

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

greptile-apps

PR Summary

(updates since last review)

This pull request implements changes to increase the token symbol length limit from 12 to 20 characters, addressing issue #9243. The main changes include:

Updated localization files to support a parametric token symbol length, replacing fixed-length messages with dynamic ones using placeholders.
Modified the ConfirmInfoRowTextTokenUnits component to handle longer token amounts by implementing a shortenString function that truncates long amounts to 15 characters with a tooltip showing the full amount.
Removed auto-detect token and NFT modals, suggesting a shift in how token detection is handled.
Updated various test files to accommodate the new token symbol length limit.
Made changes to Snap-related components and utilities, which may indirectly support the new token symbol length.

Key points to note:

The changes are primarily focused on UI components and localization, ensuring consistent handling of longer token symbols across the application.
The implementation follows the approach suggested in the issue, making the token symbol length parametric rather than hard-coded.
While many files were touched, the core changes related to token symbol length are concentrated in a few key areas, particularly localization and the ConfirmInfoRowTextTokenUnits component.
The removal of auto-detect token functionality may be related to accommodating longer token symbols, but this change might require further explanation or documentation.

Overall, the changes appear to successfully implement the requested feature while maintaining consistency across the application. However, it would be beneficial to have more context on the removal of auto-detect functionality and its relation to the increased token symbol length.

_{288 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

…LENGTH.

adjust user interface.

miladtsx · 2024-08-21T21:23:57Z

Hey @bergeron, thanks for your feedback.
I made some UI adjustments and tested them manually as much as possible.

I also adjusted MetaMask Core to support this change.

Looking forward to your feedback.

github-actions · 2024-11-11T18:05:42Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

legobeat · 2024-11-13T12:06:55Z

not stale

aspiers · 2024-11-13T18:43:29Z

Correct, not stale, and this stale bot is also counter-productive.

miladtsx requested a review from a team as a code owner February 7, 2023 15:54

miladtsx requested a review from jpuri February 7, 2023 15:54

miladtsx changed the title ~~Remove the Token Symbol length limit. #9243~~ Increase Token Symbol Length Feb 7, 2023

miladtsx force-pushed the remove_symbol_length_limit_9243 branch from 83278d1 to 2456926 Compare February 7, 2023 19:28

miladtsx changed the title ~~Increase Token Symbol Length~~ Increase Token Symbol Length to 100 Feb 8, 2023

miladtsx changed the title ~~Increase Token Symbol Length to 100~~ Increase Token Symbol Length to 100 Characters Feb 8, 2023

miladtsx mentioned this pull request Feb 8, 2023

Increase Token Symbol Length #9243

Open

miladtsx force-pushed the remove_symbol_length_limit_9243 branch from 2456926 to dc2de82 Compare February 22, 2023 09:18

legobeat force-pushed the remove_symbol_length_limit_9243 branch from dc2de82 to 162fc2d Compare April 27, 2023 04:07

legobeat reviewed Apr 27, 2023

View reviewed changes

miladtsx and others added 3 commits May 8, 2023 07:05

Remove the Token Symbol length limit. MetaMask#9243

f35f729

To prevent misuse, limit the length to 100

8069c01

lint fix

57acbca

miladtsx force-pushed the remove_symbol_length_limit_9243 branch from 97d28c9 to 57acbca Compare May 8, 2023 07:05

Make it parametric

84c1635

miladtsx changed the title ~~Increase Token Symbol Length to 100 Characters~~ Make the valid Token Symbol Length Parametric May 8, 2023

miladtsx requested a review from legobeat May 8, 2023 07:35

github-actions bot added stale issues and PRs marked as stale and removed stale issues and PRs marked as stale labels Jul 20, 2023

Merge branch 'develop' into remove_symbol_length_limit_9243

d245012

github-actions bot added the stale issues and PRs marked as stale label Sep 23, 2023

legobeat requested review from a team September 24, 2023 23:41

github-actions bot removed the stale issues and PRs marked as stale label Sep 25, 2023

vthomas13 added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label May 28, 2024

github-actions bot added stale issues and PRs marked as stale and removed stale issues and PRs marked as stale labels Aug 2, 2024

Merge branch 'develop' into remove_symbol_length_limit_9243

8d813c1

greptile-apps bot reviewed Aug 11, 2024

View reviewed changes

Merge branch 'MetaMask:develop' into remove_symbol_length_limit_9243

9770c78

greptile-apps bot reviewed Aug 20, 2024

View reviewed changes

miladtsx and others added 7 commits August 21, 2024 11:49

fix(comment): typo.

208e4be

refactor(ellipsify): only apply if the length is more than ELLIPSIFY_…

8662100

…LENGTH.

chore(rename): token symbol length.

f8e573b

feat(token_symbol): ellipsify.

9e5f028

fix(search): make the symbol uppercase when searching.

bcb93bc

chore(formatting): apply linter.

35fadb1

Merge pull request #1 from miladtsx/feat/dynamic_symbol_length_limit

d6cb9da

adjust user interface.

miladtsx requested review from a team as code owners August 21, 2024 21:06

Merge branch 'develop' into remove_symbol_length_limit_9243

b381a76

miladtsx mentioned this pull request Aug 21, 2024

Feat/dynamic symbol length limit MetaMask/core#4635

Open

legobeat mentioned this pull request Sep 17, 2024

feat: Increase token symbol maximum character length from 11 to 64 #27175

Open

7 tasks

github-actions bot added the stale issues and PRs marked as stale label Nov 11, 2024

github-actions bot removed the stale issues and PRs marked as stale label Nov 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make the valid Token Symbol Length Parametric #17642

feat: Make the valid Token Symbol Length Parametric #17642

miladtsx commented Feb 7, 2023 •

edited

Loading

github-actions bot commented Feb 7, 2023 •

edited

Loading

miladtsx commented Feb 7, 2023

matrixise commented Apr 4, 2023

legobeat Apr 27, 2023

miladtsx Jul 20, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Sep 23, 2023

github-actions bot commented Nov 24, 2023

fredwes commented May 27, 2024

legobeat commented May 27, 2024

bergeron commented Jun 3, 2024

github-actions bot commented Aug 2, 2024

greptile-apps bot left a comment

codecov bot commented Aug 11, 2024

greptile-apps bot left a comment

miladtsx commented Aug 21, 2024

github-actions bot commented Nov 11, 2024

legobeat commented Nov 13, 2024

aspiers commented Nov 13, 2024

feat: Make the valid Token Symbol Length Parametric #17642

Are you sure you want to change the base?

feat: Make the valid Token Symbol Length Parametric #17642

Conversation

miladtsx commented Feb 7, 2023 • edited Loading

github-actions bot commented Feb 7, 2023 • edited Loading

miladtsx commented Feb 7, 2023

matrixise commented Apr 4, 2023

legobeat Apr 27, 2023

Choose a reason for hiding this comment

miladtsx Jul 20, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2023

github-actions bot commented Sep 23, 2023

github-actions bot commented Nov 24, 2023

fredwes commented May 27, 2024

legobeat commented May 27, 2024

bergeron commented Jun 3, 2024

github-actions bot commented Aug 2, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

codecov bot commented Aug 11, 2024

Codecov Report

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

miladtsx commented Aug 21, 2024

github-actions bot commented Nov 11, 2024

legobeat commented Nov 13, 2024

aspiers commented Nov 13, 2024

miladtsx commented Feb 7, 2023 •

edited

Loading

github-actions bot commented Feb 7, 2023 •

edited

Loading