Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add brad-decker as codeowner of .circle/ folder #17648

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

brad-decker
Copy link
Contributor

Explanation

Currently changes to circleci folder require review from library-admins, which is good because we want to be extra careful about the circleci configuration. However, only one member of that team are currently on the extension team and therefore getting prs merged around these changes are difficult. I have added myself to the list as an additional owner to help with reviews of these prs.

@brad-decker brad-decker marked this pull request as ready for review February 7, 2023 18:44
@brad-decker brad-decker requested review from a team and kumavis as code owners February 7, 2023 18:44
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [23c1be6]
Page Load Metrics (1290 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96154116157
domContentLoaded101716051265248119
load102116601290241116
domInteractive101716051265248119
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@brad-decker brad-decker merged commit 4cb2e57 into develop Feb 8, 2023
@brad-decker brad-decker deleted the add-brad-as-codeowner-circleci branch February 8, 2023 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants