Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Icons: Stop using FA in TransactionActivityLog #17667

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 8, 2023

Explanation

Replaces activity log FA icons with new icon library

Screenshots/Screencaps

Can be seen via Storybook http://localhost:6006/?path=/docs/components-app-transactionactivitylog-transactionactivitylogicon--default-story

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner February 8, 2023 23:15
@darkwing darkwing requested a review from hmalik88 February 8, 2023 23:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [a81e24d]
Page Load Metrics (1551 ± 152 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1082021472412
domContentLoaded109121701519310149
load109121701551316152
domInteractive109121701519310149

@darkwing darkwing marked this pull request as draft February 10, 2023 00:57
@darkwing darkwing marked this pull request as ready for review February 14, 2023 18:00
garrettbear
garrettbear previously approved these changes Feb 16, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [e86d37a]
Page Load Metrics (1569 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint98157119147
domContentLoaded1318172015389345
load14071812156910450
domInteractive1318172015389345
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@darkwing darkwing merged commit 1f9b5a2 into develop Feb 21, 2023
@darkwing darkwing deleted the activity-log-icons branch February 21, 2023 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants