[FLASK] BREAKING - snaps-monorepo@0.30.0 #17718

hmalik88 · 2023-02-10T16:54:37Z

wallet_snap_* permission was removed in favor of wallet_snap and the use of caveats to track dapp <> snap permissions, this PR makes changes to account for the new permission and adds a migration to migrate from the old permissions.
Changes made to account for the new webassembly endowment & disablement of eth_accounts.
Snaps packages updated to latest release.
- snap_confirm rpc method was removed.

Please see parent issue https://github.com/MetaMask/MetaMask-planning/issues/297.

…tion

github-actions · 2023-02-10T16:54:49Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

GuillaumeRx · 2023-02-10T20:39:53Z

+10 rep. for the meme

…ssion description call

socket-security · 2023-02-15T22:42:42Z

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Powered by socket.dev

app/_locales/en/messages.json

app/_locales/ko/messages.json

app/_locales/tl/messages.json

app/_locales/tr/messages.json

app/_locales/zh_CN/messages.json

metamaskbot · 2023-03-07T12:16:28Z

Builds ready [973abd1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1429 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	142	105	12	6
		domContentLoaded	1215	1759	1414	120	57
		load	1246	1759	1429	114	55
		domInteractive	1215	1759	1414	120	57

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-07T13:14:31Z

Builds ready [1171b08]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1569 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	343	140	58	28
		domContentLoaded	1313	1747	1545	98	47
		load	1313	1747	1569	103	49
		domInteractive	1313	1747	1545	98	47

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-07T15:45:16Z

Builds ready [875088d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1723 ± 141 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	282	146	50	24
		domContentLoaded	1447	2801	1700	293	141
		load	1447	2820	1723	295	141
		domInteractive	1447	2800	1700	293	141

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-07T16:20:17Z

Builds ready [d89877e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1627 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	192	129	26	13
		domContentLoaded	1223	2094	1608	254	122
		load	1223	2094	1627	252	121
		domInteractive	1223	2093	1608	254	122

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

Gudahtt · 2023-03-07T22:13:59Z

I haven't had time to fully review this, but I have confirmed that my previous suggestions have been addressed/resolved. The new migration looks like it comprehensively checks for invalid input 👍

metamaskbot · 2023-03-07T23:13:41Z

Builds ready [1045b9f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1507 ± 35 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	127	111	9	4
		domContentLoaded	1270	1534	1469	53	26
		load	1270	1607	1507	73	35
		domInteractive	1270	1534	1469	53	26

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-08T15:36:36Z

Builds ready [bbe7281]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1498 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	153	116	12	6
		domContentLoaded	1284	1692	1474	110	53
		load	1284	1692	1498	115	55
		domInteractive	1284	1692	1474	110	53

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-08T17:43:59Z

Builds ready [b15b9ba]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1668 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	156	119	16	8
		domContentLoaded	1373	1925	1640	133	64
		load	1373	2019	1668	143	69
		domInteractive	1373	1925	1640	133	64

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-08T18:34:18Z

Builds ready [0c7a772]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1649 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	371	142	57	27
		domContentLoaded	1316	1993	1637	202	97
		load	1395	1993	1649	193	92
		domInteractive	1315	1993	1637	202	97

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 12704 bytes
ui: 0 bytes
common: 0 bytes

hmalik88 added 3 commits February 4, 2023 21:07

updated snap permission to wallet_snap, updated tests and added migra…

c2b4e1f

…tion

updated snap packages

1047595

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

83aa95c

hmalik88 requested a review from a team as a code owner February 10, 2023 16:54

hmalik88 requested a review from jpuri February 10, 2023 16:54

hmalik88 added 8 commits February 10, 2023 11:56

yarn.lock fix

e88824c

fixed errors

df1b8b6

override policy

d880ae3

update policy

d1c4c8b

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

cab57a3

undo override

85c03bc

updated localization message descriptions

fc60da6

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

543d090

hmalik88 added 6 commits February 13, 2023 13:58

updated lavamoat policy

f58c1b5

more policy updates

5d00502

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

3e07d66

update permission controller version

f2abe5a

update policy

d50ec2b

update fixture builder

58a5c11

hmalik88 marked this pull request as draft February 14, 2023 23:02

hmalik88 added 6 commits February 14, 2023 18:08

updated code to include permission value to satisfy wallet_snap permi…

25a0be8

…ssion description call

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

7e72e83

fix import issue

c73959c

update test-snaps version

b04b21e

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

81ac499

added missing actions, added snap permission dedupe function

474083b

prettier fix

f25b9cc

hmalik88 added 3 commits March 7, 2023 05:45

revert locale message change

9f0f3ee

fix el message

457a979

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

973abd1

FrederikBolding reviewed Mar 7, 2023

View reviewed changes

reverted changes

1171b08

FrederikBolding previously approved these changes Mar 7, 2023

View reviewed changes

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

875088d

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

d89877e

hmalik88 dismissed FrederikBolding’s stale review via d89877e March 7, 2023 15:54

FrederikBolding previously approved these changes Mar 7, 2023

View reviewed changes

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

1045b9f

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

bbe7281

hmalik88 dismissed FrederikBolding’s stale review via bbe7281 March 8, 2023 15:08

FrederikBolding approved these changes Mar 8, 2023

View reviewed changes

hmalik88 added 2 commits March 8, 2023 11:15

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

b15b9ba

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

b1ff6c6

GuillaumeRx approved these changes Mar 8, 2023

View reviewed changes

Merge branch 'develop' into hm/migrate-snap-permissions-to-caveats

0c7a772

hmalik88 merged commit 7086494 into develop Mar 8, 2023

hmalik88 deleted the hm/migrate-snap-permissions-to-caveats branch March 8, 2023 18:29

github-actions bot locked and limited conversation to collaborators Mar 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] BREAKING - snaps-monorepo@0.30.0 #17718

[FLASK] BREAKING - snaps-monorepo@0.30.0 #17718

hmalik88 commented Feb 10, 2023 •

edited

Loading

github-actions bot commented Feb 10, 2023

GuillaumeRx commented Feb 10, 2023

socket-security bot commented Feb 15, 2023 •

edited

Loading

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

Gudahtt commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 8, 2023

metamaskbot commented Mar 8, 2023

metamaskbot commented Mar 8, 2023

[FLASK] BREAKING - snaps-monorepo@0.30.0 #17718

[FLASK] BREAKING - snaps-monorepo@0.30.0 #17718

Conversation

hmalik88 commented Feb 10, 2023 • edited Loading

github-actions bot commented Feb 10, 2023

GuillaumeRx commented Feb 10, 2023

socket-security bot commented Feb 15, 2023 • edited Loading

Socket Security Pull Request Report

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

Gudahtt commented Mar 7, 2023

metamaskbot commented Mar 7, 2023

metamaskbot commented Mar 8, 2023

metamaskbot commented Mar 8, 2023

metamaskbot commented Mar 8, 2023

hmalik88 commented Feb 10, 2023 •

edited

Loading

socket-security bot commented Feb 15, 2023 •

edited

Loading