Updating Label component #17731
Merged
Updating Label component #17731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
added
area-UI
| className={classnames( | ||
| 'mm-form-text-field__help-text', | ||
| helpTextProps?.className, | ||
| )} | ||
| error={error} | ||
| marginTop={1} | ||
| {...helpTextProps} |
There was a problem hiding this comment.
Ensures the default className isn't overridden. Have added test to check
| .mm-form-text-field__help-text { | ||
| opacity: var(--help-text-opacity-disabled); | ||
| opacity: var(--text-opacity-disabled); | ||
| cursor: default; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Need to move disabled styles to FormTextField
georgewrmarshall
requested review from
danjm,
garrettbear and
NidhiKJha
and removed request for
danjm
Builds ready [e2e2f65]
Page Load Metrics (1179 ± 109 ms)
|
garrettbear
approved these changes
Feb 14, 2023
NidhiKJha
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Updating the
Labelcomponent based on audit and insight report.Removed
disabledonLabelcomponentRemoved
disabledstory and docsUpdated
FormTextFieldwith new method of disabled stylesAdd more tests to check that classNames still work for
HelpTextandLabelinsideFormTextFieldhttps://www.figma.com/file/aGW8sk6X6Jf9ac0MRMD4kX/TextField-Audit?node-id=282%3A22&t=uXWtYPu6jWtwEwXT-1
Screenshots/Screencaps
Before
before.mov
After
after.mov
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.