Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix url for flask build #17784

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: fix url for flask build #17784

merged 1 commit into from
Feb 16, 2023

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Feb 16, 2023

Explanation

This MR fix the url for downloading flask artifacts.

You can try build(flask) in the downstairs comment area:
#17784 (comment)

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b86eeb3]
Page Load Metrics (1663 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint104148124147
domContentLoaded1450178416329546
load1450178416638240
domInteractive1450178416329546
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though it seems that the beta builds have the exact same problem. That can be fixed just a couple of lines up from here

@DDDDDanica
Copy link
Contributor Author

@Gudahtt thanks for reviewing, the beta build will be covered here as part of automation task ~ it will differ from flask one actually when we generate flask for beta commits, the solution is a bit more complex ~

@Gudahtt
Copy link
Member

Gudahtt commented Feb 16, 2023

I just mean the beta builds linked in the metamaskbot comment. Similar to Flask, these are just preview builds for people working on PRs that only affect beta/Flask/etc. These simple preview builds might still be useful for beta, independently of the work to trigger the "real" builds only when we want a real build. Not a big deal though.

@DDDDDanica DDDDDanica merged commit d8940aa into develop Feb 16, 2023
@DDDDDanica DDDDDanica deleted the fix/flask-build branch February 16, 2023 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants