-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix url for flask build #17784
fix: fix url for flask build #17784
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3eed72d
to
b86eeb3
Compare
Builds ready [b86eeb3]
Page Load Metrics (1663 ± 40 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Though it seems that the beta builds have the exact same problem. That can be fixed just a couple of lines up from here
I just mean the beta builds linked in the |
Explanation
This MR fix the url for downloading flask artifacts.
You can try build(flask) in the downstairs comment area:
#17784 (comment)
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.