Ux: Icon: Update fa-eye with ICON_NAMES.EYE

[NidhiKJha]

Explanation

Removes the usage of both the fa-eye with ICON_NAMES.EYE

Screenshots/Screencaps

Before

After

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[digiwand]

Hi @georgewrmarshall,

I'm wondering, where did the new icons come from? If we didn't individually select them by using a bundled set, I wonder if we should consider preserving some old icons and integrating them into the new system

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

LGTM - once you fix linting issues

[georgewrmarshall]

Hey @digiwand, I believe Sara decided on the initial set of icons based on the IA/Nav redesign but we are working to be backwards compatible with what already exists in the extension. Adding the ones we are missing could be a good solution for the time being cc @Akatori-Design https://www.figma.com/file/Ne19tqQetZUNFBPROgu3qm/Icon-Audit?node-id=104%3A109&t=rb33g7TdF27DACsz-1

[digiwand]

@georgewrmarshall I see. Thanks for the info!

[digiwand]

Lgtm!

[metamaskbot]

Builds ready [66bf33d]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1559 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	129	111	9	4
		domContentLoaded	1313	1706	1527	78	37
		load	1394	1706	1559	75	36
		domInteractive	1313	1706	1527	78	37

Bundle size diffs

• background: 0 bytes
• ui: 519 bytes
• common: 0 bytes

[digiwand]

[suggestion] I believe we could replace lines 18-21 w/

import { Icon, ICON_NAMES } from '../../components/component-library';
import { Color } from '../constants/design-system';
///: BEGIN:ONLY_INCLUDE_IN(flask)
import { SNAPS_METADATA } from '../../../shared/constants/snaps';
import { coinTypeToProtocolName, getSnapDerivationPathName } from './util';
///: END:ONLY_INCLUDE_IN

to avoid // eslint-disable-line no-unused-vars