Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Icon: Replace fa-user #17809

Merged
merged 2 commits into from
Feb 21, 2023
Merged

UX Icon: Replace fa-user #17809

merged 2 commits into from
Feb 21, 2023

Conversation

NidhiKJha
Copy link
Member

Explanation

Replaces instances of fa-user with USER icons.

Screenshots/Screencaps

Before

b

After

hjh

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in the browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@NidhiKJha NidhiKJha requested a review from a team as a code owner February 17, 2023 15:15
@NidhiKJha NidhiKJha requested a review from danjm February 17, 2023 15:15
@metamaskbot
Copy link
Collaborator

Builds ready [d6fbac1]
Page Load Metrics (1655 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint100141118126
domContentLoaded14491858161211153
load14831988165513665
domInteractive14491858161211153
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@NidhiKJha NidhiKJha merged commit 123098d into develop Feb 21, 2023
@NidhiKJha NidhiKJha deleted the fa-user branch February 21, 2023 13:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants