UX: Remove legacy metametrics modal

[darkwing]

Explanation

The extension showed a metametrics modal on the home screen if a choice hadn't been chosen. This modal is outdated and no longer necessary.

This modal was implemented 4 years ago (#6171) and would only be hit by persons who haven't opened their wallet in that time.

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [cc6216b]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1478 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	132	109	12	6
		domContentLoaded	1203	1584	1455	92	44
		load	1261	1645	1478	99	47
		domInteractive	1203	1584	1455	92	44

Bundle size diffs

• background: 0 bytes
• ui: -8479 bytes
• common: 0 bytes

[codecov-commenter]

Codecov Report

Merging #17817 (cc6216b) into develop (3fa167e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop   #17817      +/-   ##
===========================================
- Coverage    62.23%   62.22%   -0.01%     
===========================================
  Files          902      900       -2     
  Lines        35144    35118      -26     
  Branches      8890     8887       -3     
===========================================
- Hits         21871    21851      -20     
+ Misses       13273    13267       -6     

Impacted Files	Coverage Δ
ui/components/app/modals/modal.js	0.00% <ø> (ø)
ui/pages/unlock-page/unlock-page.container.js	76.19% <ø> (-1.08%)	⬇️
ui/pages/unlock-page/unlock-page.component.js	85.71% <100.00%> (+7.94%)	⬆️
app/scripts/metamask-controller.js	60.33% <0.00%> (-0.25%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[metamaskbot]

Builds ready [50b51d8]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1600 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	167	122	20	10
		domContentLoaded	1470	1730	1576	81	39
		load	1470	1855	1600	106	51
		domInteractive	1470	1730	1576	81	39

Bundle size diffs

• background: 0 bytes
• ui: -8614 bytes
• common: 0 bytes