Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CancelTransaction modal #17819

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

darkwing
Copy link
Contributor

Explanation

Removes an unused modal component.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner February 19, 2023 02:21
@darkwing darkwing requested a review from hmalik88 February 19, 2023 02:21
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fc3152e]
Page Load Metrics (1550 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint98149112126
domContentLoaded1396164015156531
load1396168715507134
domInteractive1396164015156531
Bundle size diffs
  • background: 0 bytes
  • ui: -9261 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

Codecov Report

Merging #17819 (fc3152e) into develop (3fa167e) will decrease coverage by 0.05%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop   #17819      +/-   ##
===========================================
- Coverage    62.23%   62.18%   -0.05%     
===========================================
  Files          902      900       -2     
  Lines        35144    35107      -37     
  Branches      8890     8888       -2     
===========================================
- Hits         21871    21830      -41     
- Misses       13273    13277       +4     
Impacted Files Coverage Δ
ui/components/app/modals/modal.js 0.00% <ø> (ø)
...er-components/with-modal-props/with-modal-props.js 88.89% <0.00%> (-11.11%) ⬇️
app/scripts/metamask-controller.js 60.33% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@darkwing darkwing merged commit 1b382e9 into develop Feb 21, 2023
@darkwing darkwing deleted the remove-cancel-transaction-modal-2 branch February 21, 2023 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants