Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Icon: Updated Icon for Disclosure #17877

Merged
merged 8 commits into from
Mar 9, 2023
Merged

UX Icon: Updated Icon for Disclosure #17877

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee2ce06
updated fa-add
NidhiKJha Feb 23, 2023
3fa89f0
updated summary icon
NidhiKJha Feb 23, 2023
50cbf8a
updated styles for disclosure
NidhiKJha Mar 6, 2023
efd642d
updated margin value
NidhiKJha Mar 6, 2023
8bd85a8
Merge branch 'develop' into fa-add
NidhiKJha Mar 6, 2023
d7536c2
Merge branch 'develop' into fa-add
NidhiKJha Mar 6, 2023
408a3d0
Merge branch 'develop' into fa-add
NidhiKJha Mar 6, 2023
c8c8ac7
Merge branch 'develop' into fa-add
NidhiKJha Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ui/components/ui/disclosure/disclosure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import React, { useState, useRef, useEffect } from 'react';
import PropTypes from 'prop-types';
import classnames from 'classnames';
import { Icon, ICON_NAMES } from '../../component-library';
import { Size } from '../../../helpers/constants/design-system';

const Disclosure = ({ children, title, size }) => {
const disclosureFooterEl = useRef(null);
Expand All @@ -23,7 +25,12 @@ const Disclosure = ({ children, title, size }) => {
{title ? (
<details>
<summary className="disclosure__summary">
<i className="fa fa-plus" />
<Icon
className="disclosure__summary--icon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In BEM standards would still keep this as disclosure__summary-icon and reserving the double dash -- for when it is a modifier (e.g. disclosure__summary-icon--size-xs)

Suggested change
className="disclosure__summary--icon"
className="disclosure__summary-icon"

name={ICON_NAMES.ADD}
size={Size.SM}
marginInlineEnd={2}
/>
{title}
</summary>
<div className={classnames('disclosure__content', size)}>
Expand Down
7 changes: 1 addition & 6 deletions ui/components/ui/disclosure/disclosure.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,9 @@

&__summary {
position: relative;
padding-left: 24px;
padding-bottom: 10px;
font-weight: bold;

i {
margin-inline-start: -20px;
margin-inline-end: 10px;
}
display: flex;

&::-webkit-details-marker,
&::marker {
Expand Down