Fixing FormTextField test

[georgewrmarshall]

Explanation

A test was creating an error in the console in FormTextField

Screenshots/Screencaps

Before

After

Tests are fixed

Manual Testing Steps

• Go to the storybook build on this branch
• Search FormTextField in the search bar
• Check HelpText story works with error or use the controls to turn error on while there is some HelpText

For tests check the CI unit test build or pull this branch and run

yarn jest ui/components/component-library

And check the console is all greeeen 🍏 📗 🟢

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [42bfdb9]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2001 ± 140 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	248	160	40	19
		domContentLoaded	1571	2607	1961	289	139
		load	1579	2739	2001	293	140
		domInteractive	1571	2607	1961	289	139

Bundle size diffs

• background: 0 bytes
• ui: -8 bytes
• common: 0 bytes

[metamaskbot]

Builds ready [e5521f1]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1591 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	308	123	48	23
		domContentLoaded	1299	1746	1551	105	50
		load	1380	1808	1591	101	48
		domInteractive	1299	1746	1551	105	50

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #17939 (e5521f1) into develop (c8e8db2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #17939      +/-   ##
===========================================
+ Coverage    63.44%   63.45%   +0.01%     
===========================================
  Files          903      903              
  Lines        35267    35267              
  Branches      8920     8920              
===========================================
+ Hits         22373    22376       +3     
+ Misses       12894    12891       -3     

Impacted Files	Coverage Δ
app/scripts/metamask-controller.js	60.18% <0.00%> (+0.25%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.