Fix #17948 - Allow editing of NFT sends

[darkwing]

Explanation

• Fixes [Bug]: Cannot Edit a Send NFT from inside MetaMask #17948

The Edit link isn't displaying because confirm-transaction-base.component.js isn't being provided an onEdit prop. The problem ultimately is happening because ui/pages/confirm-transaction/confirm-token-transaction-switch.js renders a ConfirmTokenTransactionBase by route CONFIRM_TRANSFER_FROM_PATH without the onEdit.

Screenshots/Screencaps

EditNFTSend.mp4

Manual Testing Steps

1. Enable the NFT feature with NFTS_V1 yarn start
2. Start the NFT send flow
3. On the confirmation screen, click "Edit"
4. See the same NFT still selected
5. Choose a different NFT
6. On the confirmation screen, click "edit"

The proper NFT should display on the edit and confirmation screens.

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [1fcf96d]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1558 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	134	112	10	5
		domContentLoaded	1256	1878	1537	141	68
		load	1256	1878	1558	157	75
		domInteractive	1256	1878	1537	141	68

Bundle size diffs

• background: 0 bytes
• ui: 648 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #17970 (82edb63) into develop (786a74d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #17970      +/-   ##
===========================================
- Coverage    63.45%   63.43%   -0.01%     
===========================================
  Files          903      903              
  Lines        35263    35270       +7     
  Branches      8918     8918              
===========================================
  Hits         22373    22373              
- Misses       12890    12897       +7     

Impacted Files	Coverage Δ
...rm-transaction/confirm-token-transaction-switch.js	5.26% <0.00%> (-3.07%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[metamaskbot]

Builds ready [82edb63]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1529 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	173	115	22	10
		domContentLoaded	1283	1676	1495	115	55
		load	1348	1768	1529	121	58
		domInteractive	1283	1676	1495	115	55

Bundle size diffs

• background: 0 bytes
• ui: 648 bytes
• common: 0 bytes

[danjm]

I don't think we want to allow editing of these transactions if they are coming from a dapp. I'll run this code and test it to see if I can make any suggestions in that regard

[danjm]

I don't think we want to allow editing of these transactions if they are coming from a dapp. I'll run this code and test it to see if I can make any suggestions in that regard

Actually, after some testing, I think this is safe