Fix nft test state

[tmashuang]

Explanation

Adjust nft mock state to better match prod state.

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [e2a242f]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1766 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	322	134	45	22
		domContentLoaded	1417	2127	1720	153	73
		load	1418	2127	1766	167	80
		domInteractive	1417	2127	1720	153	73

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[digiwand]

looks like we'll need to fix tests related to /test/e2e/nft/import-erc1155.spec.js as well
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/38564/workflows/da2f3b97-f190-45d3-948b-7f43c12f177c/jobs/1052191/artifacts

[tmashuang]

@digiwand Correct me if I am wrong, I thought that the e2e tests uses fixture state that is totally separate from the mock-state.json that we use for unit tests ie test/e2e/fixture-builder.js.

Regardless, the newly added erc1155 test seems to have introduced more flaky tests. There is a related, in-progress fix for that specific collection toggle, #17972, that might fix the flaky tests we seen. Will keep an 👀 on that to see if that fixes it.

[digiwand]

@tmashuang gotchya, thanks for the info! In that case, giving this the green light for when tests pan out

[metamaskbot]

Builds ready [fcf9c47]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1581 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	152	122	16	8
		domContentLoaded	1303	1757	1552	100	48
		load	1408	1782	1581	94	45
		domInteractive	1303	1757	1552	100	48

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #17981 (fcf9c47) into develop (c8e8db2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #17981   +/-   ##
========================================
  Coverage    63.44%   63.44%           
========================================
  Files          903      903           
  Lines        35267    35267           
  Branches      8920     8920           
========================================
  Hits         22373    22373           
  Misses       12894    12894           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.