Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment keyring controller version #18036

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Mar 7, 2023

Explanation

Update the minimum version in the semver range to fix the bug described here.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [3b0b1c1]
Page Load Metrics (1630 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint933681345727
domContentLoaded13441960160512861
load13451960163012761
domInteractive13441960160512861
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 34 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #18036 (a51d33a) into develop (5c30fee) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #18036      +/-   ##
===========================================
+ Coverage    63.45%   63.46%   +0.01%     
===========================================
  Files          903      903              
  Lines        35264    35264              
  Branches      8919     8919              
===========================================
+ Hits         22374    22377       +3     
+ Misses       12890    12887       -3     
Impacted Files Coverage Δ
app/scripts/metamask-controller.js 60.18% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

DDDDDanica
DDDDDanica previously approved these changes Mar 7, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [a51d33a]
Page Load Metrics (1547 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95152122189
domContentLoaded12781731152610852
load12781824154711455
domInteractive12781731152610852
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 34 bytes
  • ui: 0 bytes
  • common: 0 bytes

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedronfigueiredo pedronfigueiredo merged commit 6222cf0 into develop Mar 8, 2023
@pedronfigueiredo pedronfigueiredo deleted the feat/increment-keyring-controller branch March 8, 2023 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants